1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
|
#!./perl
#
# Copyright (c) 2002 Slaven Rezic
#
# You may redistribute only under the same terms as Perl 5, as specified
# in the README file that comes with the distribution.
#
sub BEGIN {
unshift @INC, 't';
require Config; import Config;
if ($ENV{PERL_CORE} and $Config{'extensions'} !~ /\bStorable\b/) {
print "1..0 # Skip: Storable was not built\n";
exit 0;
}
}
use strict;
BEGIN {
if (!eval q{
use Test::More;
use B::Deparse 0.61;
use 5.006;
1;
}) {
print "1..0 # skip: tests only work with B::Deparse 0.61 and at least perl 5.6.0\n";
exit;
}
require File::Spec;
if ($File::Spec::VERSION < 0.8) {
print "1..0 # Skip: newer File::Spec needed\n";
exit 0;
}
}
BEGIN { plan tests => 59 }
use Storable qw(retrieve store nstore freeze nfreeze thaw dclone);
use Safe;
#$Storable::DEBUGME = 1;
use vars qw($freezed $thawed @obj @res $blessed_code);
$blessed_code = bless sub { "blessed" }, "Some::Package";
{ package Another::Package; sub foo { __PACKAGE__ } }
{
no strict; # to make the life for Safe->reval easier
sub code { "JAPH" }
}
local *FOO;
@obj =
([\&code, # code reference
sub { 6*7 },
$blessed_code, # blessed code reference
\&Another::Package::foo, # code in another package
sub ($$;$) { 0 }, # prototypes
sub { print "test\n" },
\&Test::More::ok, # large scalar
],
{"a" => sub { "srt" }, "b" => \&code},
sub { ord("a")-ord("7") },
\&code,
\&dclone, # XS function
sub { open FOO, "/" },
);
$Storable::Deparse = 1;
$Storable::Eval = 1;
######################################################################
# Test freeze & thaw
$freezed = freeze $obj[0];
$thawed = thaw $freezed;
is($thawed->[0]->(), "JAPH");
is($thawed->[1]->(), 42);
is($thawed->[2]->(), "blessed");
is($thawed->[3]->(), "Another::Package");
is(prototype($thawed->[4]), prototype($obj[0]->[4]));
######################################################################
$freezed = freeze $obj[1];
$thawed = thaw $freezed;
is($thawed->{"a"}->(), "srt");
is($thawed->{"b"}->(), "JAPH");
######################################################################
$freezed = freeze $obj[2];
$thawed = thaw $freezed;
is($thawed->(), 42);
######################################################################
$freezed = freeze $obj[3];
$thawed = thaw $freezed;
is($thawed->(), "JAPH");
######################################################################
eval { $freezed = freeze $obj[4] };
like($@, qr/The result of B::Deparse::coderef2text was empty/);
######################################################################
# Test dclone
my $new_sub = dclone($obj[2]);
is($new_sub->(), $obj[2]->());
######################################################################
# Test retrieve & store
store $obj[0], 'store';
$thawed = retrieve 'store';
is($thawed->[0]->(), "JAPH");
is($thawed->[1]->(), 42);
is($thawed->[2]->(), "blessed");
is($thawed->[3]->(), "Another::Package");
is(prototype($thawed->[4]), prototype($obj[0]->[4]));
######################################################################
nstore $obj[0], 'store';
$thawed = retrieve 'store';
unlink 'store';
is($thawed->[0]->(), "JAPH");
is($thawed->[1]->(), 42);
is($thawed->[2]->(), "blessed");
is($thawed->[3]->(), "Another::Package");
is(prototype($thawed->[4]), prototype($obj[0]->[4]));
######################################################################
# Security with
# $Storable::Eval
# $Storable::Deparse
{
local $Storable::Eval = 0;
for my $i (0 .. 1) {
$freezed = freeze $obj[$i];
$@ = "";
eval { $thawed = thaw $freezed };
like($@, qr/Can\'t eval/);
}
}
{
local $Storable::Deparse = 0;
for my $i (0 .. 1) {
$@ = "";
eval { $freezed = freeze $obj[$i] };
like($@, qr/Can\'t store CODE items/);
}
}
{
local $Storable::Eval = 0;
local $Storable::forgive_me = 1;
for my $i (0 .. 4) {
$freezed = freeze $obj[0]->[$i];
$@ = "";
eval { $thawed = thaw $freezed };
is($@, "");
like($$thawed, qr/^sub/);
}
}
{
local $Storable::Deparse = 0;
local $Storable::forgive_me = 1;
my $devnull = File::Spec->devnull;
open(SAVEERR, ">&STDERR");
open(STDERR, ">$devnull") or
( print SAVEERR "Unable to redirect STDERR: $!\n" and exit(1) );
eval { $freezed = freeze $obj[0]->[0] };
open(STDERR, ">&SAVEERR");
is($@, "");
isnt($freezed, '');
}
{
my $safe = new Safe;
local $Storable::Eval = sub { $safe->reval(shift) };
$freezed = freeze $obj[0]->[0];
$@ = "";
eval { $thawed = thaw $freezed };
is($@, "");
is($thawed->(), "JAPH");
$freezed = freeze $obj[0]->[6];
eval { $thawed = thaw $freezed };
# The "Code sub ..." error message only appears if Log::Agent is installed
like($@, qr/(trapped|Code sub)/);
if (0) {
# Disable or fix this test if the internal representation of Storable
# changes.
skip("no malicious storable file check", 1);
} else {
# Construct malicious storable code
$freezed = nfreeze $obj[0]->[0];
my $bad_code = ';open FOO, "/badfile"';
# 5th byte is (short) length of scalar
my $len = ord(substr($freezed, 4, 1));
substr($freezed, 4, 1, chr($len+length($bad_code)));
substr($freezed, -1, 0, $bad_code);
$@ = "";
eval { $thawed = thaw $freezed };
like($@, qr/(trapped|Code sub)/);
}
}
{
my $safe = new Safe;
# because of opcodes used in "use strict":
$safe->permit(qw(:default require caller));
local $Storable::Eval = sub { $safe->reval(shift) };
$freezed = freeze $obj[0]->[1];
$@ = "";
eval { $thawed = thaw $freezed };
is($@, "");
is($thawed->(), 42);
}
{
{
package MySafe;
sub new { bless {}, shift }
sub reval {
my $source = $_[1];
# Here you can apply some nifty regexpes to ensure the
# safeness of the source code.
my $coderef = eval $source;
$coderef;
}
}
my $safe = new MySafe;
local $Storable::Eval = sub { $safe->reval($_[0]) };
$freezed = freeze $obj[0];
eval { $thawed = thaw $freezed };
is($@, "");
if ($@ ne "") {
fail() for (1..5);
} else {
is($thawed->[0]->(), "JAPH");
is($thawed->[1]->(), 42);
is($thawed->[2]->(), "blessed");
is($thawed->[3]->(), "Another::Package");
is(prototype($thawed->[4]), prototype($obj[0]->[4]));
}
}
{
# Check internal "seen" code
my $short_sub = sub { "short sub" }; # for SX_SCALAR
# for SX_LSCALAR
my $long_sub_code = 'sub { "' . "x"x255 . '" }';
my $long_sub = eval $long_sub_code; die $@ if $@;
my $sclr = \1;
local $Storable::Deparse = 1;
local $Storable::Eval = 1;
for my $sub ($short_sub, $long_sub) {
my $res;
$res = thaw freeze [$sub, $sub];
is(int($res->[0]), int($res->[1]));
$res = thaw freeze [$sclr, $sub, $sub, $sclr];
is(int($res->[0]), int($res->[3]));
is(int($res->[1]), int($res->[2]));
$res = thaw freeze [$sub, $sub, $sclr, $sclr];
is(int($res->[0]), int($res->[1]));
is(int($res->[2]), int($res->[3]));
}
}
|