1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
|
#!./perl
# 2 purpose file: 1-test 2-demonstrate (via args, -v -a options)
=head1 SYNOPSIS
To verify that B::Concise properly reports whether functions are XS,
perl, or optimized constant subs, we test against a few core packages
which have a stable API, and which have functions of all 3 types.
=head1 WHAT IS TESTED
5 core packages are tested; Digest::MD5, B, B::Deparse, Data::Dumper,
and POSIX. These have a mix of the 3 expected implementation types;
perl, XS, and constant (optimized constant subs).
%$testpkgs specifies what packages are tested; each package is loaded,
and the stash is scanned for the function-names in that package.
Each value in %$testpkgs is a hash-of-lists (HoL) whose keys are
implementation-types and values are lists of function-names of that type.
To keep these HoLs smaller and more manageable, they may carry an
additional 'dflt' => $impl_Type, which means that unnamed functions
are expected to be of that default implementation type. Those unnamed
functions are known from the scan of the package stash.
=head1 HOW THEY'RE TESTED
Each function is 'rendered' by B::Concise, and result is matched
against regexs for each possible implementation-type. For some
packages, some functions may be unimplemented on some platforms.
To slay this maintenance dragon, the regexs used in like() match
against renderings which indicate that there is no implementation.
If a function is implemented differently on different platforms, the
test for that function will fail on one of those platforms. These
specific functions can be skipped by a 'skip' => [ @list ] to the HoL
mentioned previously. See usage for skip in B's HoL, which avoids
testing a function which doesn't exist on non-threaded builds.
=head1 OPTIONS AND ARGUMENTS
C<-v> and C<-V> trigger 2 levels of verbosity.
C<-a> uses Module::CoreList to run all core packages through the test, which
gives some interesting results.
C<-c> causes the expected XS/non-XS results to be marked with
corrections, which are then reported at program END, in a form that's
readily cut-and-pastable into this file.
C<< -r <file> >> reads a file, as written by C<-c>, and adjusts the expected
results accordingly. The file is 'required', so @INC settings apply.
If module-names are given as args, those packages are run through the
test harness; this is handy for collecting further items to test, and
may be useful otherwise (ie just to see).
=head1 EXAMPLES
=over 4
=item ./perl -Ilib -wS ext/B/t/concise-xs.t -c Storable
Tests Storable.pm for XS/non-XS routines, writes findings (along with
test results) to stdout. You could edit results to produce a test
file, as in next example
=item ./perl -Ilib -wS ext/B/t/concise-xs.t -r ./storable
Loads file, and uses it to set expectations, and run tests
=item ./perl -Ilib -wS ext/B/t/concise-xs.t -avc > ../foo-avc 2> ../foo-avc2
Gets module list from Module::Corelist, and runs them all through the
test. Since -c is used, this generates corrections, which are saved
in a file, which is edited down to produce ../all-xs
=item ./perl -Ilib -wS ext/B/t/concise-xs.t -cr ../all-xs > ../foo 2> ../foo2
This runs the tests specified in the file created in previous example.
-c is used again, and stdout verifies that all the expected results
given by -r ../all-xs are now seen.
Looking at ../foo2, you'll see 34 occurrences of the following error:
# err: Can't use an undefined value as a SCALAR reference at
# lib/B/Concise.pm line 634, <DATA> line 1.
=back
=cut
BEGIN {
unshift @INC, 't';
require Config;
if (($Config::Config{'extensions'} !~ /\bB\b/) ){
print "1..0 # Skip -- Perl configured without B module\n";
exit 0;
}
unless ($Config::Config{useperlio}) {
print "1..0 # Skip -- Perl configured without perlio\n";
exit 0;
}
}
use Getopt::Std;
use Carp;
use Test::More 'no_plan';
require_ok("B::Concise");
my %matchers =
( constant => qr{ (?-x: is a constant sub, optimized to a \w+)
|(?-x: exists in stash, but has no START) }x,
XS => qr/ is XS code/,
perl => qr/ (next|db)state/,
noSTART => qr/ exists in stash, but has no START/,
);
my $testpkgs = {
# packages to test, with expected types for named funcs
Digest::MD5 => { perl => [qw/ import /],
dflt => 'XS' },
Data::Dumper => { XS => [qw/ bootstrap Dumpxs _vstring /],
constant => ['_bad_vsmg'],
dflt => 'perl' },
B => {
dflt => 'constant', # all but 47/297
skip => [ 'regex_padav' ], # threaded only
perl => [qw(
walksymtable walkoptree_slow walkoptree_exec
timing_info savesym peekop parents objsym debug
compile_stats clearsym class
)],
XS => [qw(
warnhook walkoptree_debug walkoptree threadsv_names
svref_2object sv_yes sv_undef sv_no save_BEGINs
regex_padav ppname perlstring opnumber minus_c
main_start main_root main_cv init_av inc_gv hash
formfeed end_av dowarn diehook defstash curstash
cstring comppadlist check_av cchar cast_I32 bootstrap
begin_av amagic_generation sub_generation address
), $] > 5.009 ? ('unitcheck_av') : ()],
},
B::Deparse => { dflt => 'perl', # 236 functions
XS => [qw( svref_2object perlstring opnumber main_start
main_root main_cv )],
constant => [qw/ ASSIGN CVf_LVALUE
CVf_METHOD LIST_CONTEXT OP_CONST OP_LIST OP_RV2SV
OP_GLOB
OP_STRINGIFY OPf_KIDS OPf_MOD OPf_REF OPf_SPECIAL
OPf_STACKED OPf_WANT OPf_WANT_LIST OPf_WANT_SCALAR
OPf_WANT_VOID OPpCONST_BARE OPpCONST_NOVER
OPpENTERSUB_AMPER OPpEXISTS_SUB OPpITER_REVERSED
OPpLVAL_INTRO OPpOUR_INTRO OPpSLICE OPpSORT_DESCEND
OPpSORT_INPLACE OPpSORT_INTEGER OPpSORT_NUMERIC
OPpSORT_REVERSE OPpREVERSE_INPLACE OPpTARGET_MY
OPpTRANS_COMPLEMENT OPpTRANS_DELETE OPpTRANS_SQUASH
PMf_CONTINUE PMf_EVAL PMf_EXTENDED PMf_FOLD PMf_GLOBAL
PMf_KEEP PMf_NONDESTRUCT PMf_SKIPWHITE RXf_PMf_CHARSET
PMf_MULTILINE PMf_ONCE PMf_SINGLELINE RXf_PMf_KEEPCOPY
POSTFIX SVf_FAKE SVf_IOK SVf_NOK SVf_POK SVf_ROK
SVpad_OUR SVs_RMG SVs_SMG SWAP_CHILDREN OPpPAD_STATE
OPpCONST_ARYBASE OPpEVAL_BYTES OPpSUBSTR_REPL_FIRST
/, $] > 5.009 ? ('RXf_SKIPWHITE') : ('PMf_SKIPWHITE'),
'CVf_LOCKED', # This ends up as a constant, pre or post 5.10
],
},
POSIX => { dflt => 'constant', # all but 252/589
skip => [qw/ _POSIX_JOB_CONTROL /, # platform varying
# Might be XS or imported from Fcntl, depending on your
# perl version:
qw / S_ISBLK S_ISCHR S_ISDIR S_ISFIFO S_ISREG /,
# Might be XS or AUTOLOADed, depending on your perl
# version:
qw /WEXITSTATUS WIFEXITED WIFSIGNALED WIFSTOPPED
WSTOPSIG WTERMSIG/,
'int_macro_int', # Removed in POSIX 1.16
],
perl => [qw/ import load_imports croak usage printf sprintf
perror AUTOLOAD /],
XS => [qw/ write wctomb wcstombs uname tzset tzname
ttyname tmpnam times tcsetpgrp tcsendbreak
tcgetpgrp tcflush tcflow tcdrain tanh tan
sysconf strxfrm strtoul strtol strtod
strftime strcoll sinh sigsuspend sigprocmask
sigpending sigaction setuid setsid setpgid
setlocale setgid read pipe pause pathconf
open nice modf mktime mkfifo mbtowc mbstowcs
mblen lseek log10 localeconv ldexp lchown
isxdigit isupper isspace ispunct isprint
islower isgraph isdigit iscntrl isalpha
isalnum getcwd frexp fpathconf
fmod floor dup2 dup difftime cuserid ctime
ctermid cosh constant close clock ceil
bootstrap atan asin asctime acos access abort
_exit sleep
/],
},
IO::Socket => { dflt => 'constant', # 157/190
perl => [qw/ timeout socktype sockopt sockname
socketpair socket sockdomain sockaddr_un
sockaddr_in shutdown setsockopt send
register_domain recv protocol peername
new listen import getsockopt croak
connected connect configure confess close
carp bind atmark accept sockaddr_in6
/, $] > 5.009 ? ('blocking') : () ],
XS => [qw/ unpack_sockaddr_un unpack_sockaddr_in
sockatmark sockaddr_family pack_sockaddr_un
pack_sockaddr_in inet_ntoa inet_aton
unpack_sockaddr_in6 pack_sockaddr_in6
/],
# skip inet_ntop and inet_pton as they're not exported by default
},
};
############
B::Concise::compile('-nobanner'); # set a silent default
getopts('vaVcr:', \my %opts) or
die <<EODIE;
usage: PERL_CORE=1 ./perl ext/B/t/concise-xs.t [-av] [module-list]
tests ability to discern XS funcs using Digest::MD5 package
-v : runs verbosely
-V : more verbosity
-a : runs all modules in CoreList
-c : writes test corrections as a Data::Dumper expression
-r <file> : reads file of tests, as written by -c
<args> : additional modules are loaded and tested
(will report failures, since no XS funcs are known apriori)
EODIE
;
if (%opts) {
require Data::Dumper;
Data::Dumper->import('Dumper');
$Data::Dumper::Sortkeys = 1;
}
my @argpkgs = @ARGV;
my %report;
if ($opts{r}) {
my $refpkgs = require "$opts{r}";
$testpkgs->{$_} = $refpkgs->{$_} foreach keys %$refpkgs;
}
unless ($opts{a}) {
unless (@argpkgs) {
foreach $pkg (sort keys %$testpkgs) {
test_pkg($pkg, $testpkgs->{$pkg});
}
} else {
foreach $pkg (@argpkgs) {
test_pkg($pkg, $testpkgs->{$pkg});
}
}
} else {
corecheck();
}
############
sub test_pkg {
my ($pkg, $fntypes) = @_;
require_ok($pkg);
# build %stash: keys are func-names, vals filled in below
my (%stash) = map
( ($_ => 0)
=> ( grep exists &{"$pkg\::$_"} # grab CODE symbols
=> grep !/__ANON__/ # but not anon subs
=> keys %{$pkg.'::'} # from symbol table
));
for my $type (keys %matchers) {
foreach my $fn (@{$fntypes->{$type}}) {
carp "$fn can only be one of $type, $stash{$fn}\n"
if $stash{$fn};
$stash{$fn} = $type;
}
}
# set default type for un-named functions
my $dflt = $fntypes->{dflt} || 'perl';
for my $k (keys %stash) {
$stash{$k} = $dflt unless $stash{$k};
}
$stash{$_} = 'skip' foreach @{$fntypes->{skip}};
if ($opts{v}) {
diag("fntypes: " => Dumper($fntypes));
diag("$pkg stash: " => Dumper(\%stash));
}
foreach my $fn (reverse sort keys %stash) {
next if $stash{$fn} eq 'skip';
my $res = checkXS("${pkg}::$fn", $stash{$fn});
if ($res ne '1') {
push @{$report{$pkg}{$res}}, $fn;
}
}
}
sub checkXS {
my ($func_name, $want) = @_;
croak "unknown type $want: $func_name\n"
unless defined $matchers{$want};
my ($buf, $err) = render($func_name);
my $res = like($buf, $matchers{$want}, "$want sub:\t $func_name");
unless ($res) {
# test failed. return type that would give success
for my $m (keys %matchers) {
return $m if $buf =~ $matchers{$m};
}
}
$res;
}
sub render {
my ($func_name) = @_;
B::Concise::reset_sequence();
B::Concise::walk_output(\my $buf);
my $walker = B::Concise::compile($func_name);
eval { $walker->() };
diag("err: $@ $buf") if $@;
diag("verbose: $buf") if $opts{V};
return ($buf, $@);
}
sub corecheck {
eval { require Module::CoreList };
if ($@) {
warn "Module::CoreList not available on $]\n";
return;
}
my $mods = $Module::CoreList::version{'5.009002'};
$mods = [ sort keys %$mods ];
print Dumper($mods);
foreach my $pkgnm (@$mods) {
test_pkg($pkgnm);
}
}
END {
if ($opts{c}) {
$Data::Dumper::Indent = 1;
print "Corrections: ", Dumper(\%report);
foreach my $pkg (sort keys %report) {
for my $type (keys %matchers) {
print "$pkg: $type: @{$report{$pkg}{$type}}\n"
if @{$report{$pkg}{$type}};
}
}
}
}
__END__
|