diff options
author | Tom Gillespie <tgbugs@gmail.com> | 2019-03-20 20:21:19 -0700 |
---|---|---|
committer | Tom Gillespie <tgbugs@gmail.com> | 2019-03-23 01:07:12 -0700 |
commit | 43512da5ced3dc7bc97f06d28b1342e9fd856e19 (patch) | |
tree | 4075c26c6e096aa616e4299fcf52b764dbb924cb /notes | |
parent | 03168dd3cb57cbafebccef0d46e00c6bbd4bb0b9 (diff) | |
download | pexpect-git-43512da5ced3dc7bc97f06d28b1342e9fd856e19.tar.gz |
pxssh.login require either username or ssh_config
If pxssh.login is called with an ssh_config then do not require username since it can be supplied via the config and some programs do not want to manage the username at all since it would require parsing the ssh config.
This commit removes the independent username parameter when formatting cmd and instead appends the flag and the username to ssh_options if a username is provided.
If neither username nor ssh_config is provided raise a TypeError in line with the error raised natively if username was not provided as a required positional argument.
Tests ensure that ssh_config lists a username for the server in question
so the user running the program does not leak. Note that ssh_config
keywords are case-insensitive.
This commit by itself fails tests because it has been modified to
simplifiy the merge commit.
Diffstat (limited to 'notes')
0 files changed, 0 insertions, 0 deletions