diff options
| author | Stanislav Malyshev <stas@php.net> | 2014-08-19 01:33:45 -0700 |
|---|---|---|
| committer | Stanislav Malyshev <stas@php.net> | 2014-08-19 01:33:45 -0700 |
| commit | 5a7039035ce22a68130af2309ff002a611976c87 (patch) | |
| tree | 87530c1ed34ffa32c50a444d93c2b17d3f6f130e | |
| parent | 88c48a4b95376a22a571b82a946431826b0dd61b (diff) | |
| parent | eb2360602e256c608ea0c5f6be0ec5ec085999f3 (diff) | |
| download | php-git-5a7039035ce22a68130af2309ff002a611976c87.tar.gz | |
Merge tag 'PHP-5.4.32' into PHP-5.4
5.4.32
* tag 'PHP-5.4.32':
5.4.32
fix potentially missing NUL termination
Fix bug #67730 - Null byte injection possible with imagexxx functions
Fixed bug #67717 - segfault in dns_get_record
Fix bug #67716 - Segfault in cdf.c
5.4.32 RC1
Conflicts:
configure.in
main/php_version.h
| -rw-r--r-- | ext/gd/gd_ctx.c | 5 | ||||
| -rw-r--r-- | main/network.c | 2 |
2 files changed, 7 insertions, 0 deletions
diff --git a/ext/gd/gd_ctx.c b/ext/gd/gd_ctx.c index bff691fad2..eafbab5896 100644 --- a/ext/gd/gd_ctx.c +++ b/ext/gd/gd_ctx.c @@ -124,6 +124,11 @@ static void _php_image_output_ctx(INTERNAL_FUNCTION_PARAMETERS, int image_type, RETURN_FALSE; } } else if (Z_TYPE_P(to_zval) == IS_STRING) { + if (CHECK_ZVAL_NULL_PATH(to_zval)) { + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Invalid 2nd parameter, filename must not contain null bytes"); + RETURN_FALSE; + } + stream = php_stream_open_wrapper(Z_STRVAL_P(to_zval), "wb", REPORT_ERRORS|IGNORE_PATH|IGNORE_URL_WIN, NULL); if (stream == NULL) { RETURN_FALSE; diff --git a/main/network.c b/main/network.c index 59ce12ef20..5e44b0e6a8 100644 --- a/main/network.c +++ b/main/network.c @@ -989,6 +989,7 @@ PHPAPI char *php_socket_strerror(long err, char *buf, size_t bufsize) buf = estrdup(errstr); } else { strncpy(buf, errstr, bufsize); + buf[bufsize?(bufsize-1):0] = 0; } return buf; #else @@ -1013,6 +1014,7 @@ PHPAPI char *php_socket_strerror(long err, char *buf, size_t bufsize) buf = estrdup(sysbuf); } else { strncpy(buf, sysbuf, bufsize); + buf[bufsize?(bufsize-1):0] = 0; } if (free_it) { |