summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRemi Collet <remi@php.net>2014-11-20 15:14:34 +0100
committerRemi Collet <remi@php.net>2014-11-21 07:55:13 +0100
commit5be75da2027ca9fe1726536ff68a5a8b3c31fa96 (patch)
tree16f2193f0f716bd32a42dc78d28676b987f9815c
parentc4ca220467a94ff361c6dbdec281b861c9d749be (diff)
downloadphp-git-5be75da2027ca9fe1726536ff68a5a8b3c31fa96.tar.gz
Fix bug #68463 listen.allowed_clients can silently result in no allowed access
Add a "There are no allowed addresses for this pool"
-rw-r--r--sapi/fpm/fpm/fastcgi.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/sapi/fpm/fpm/fastcgi.c b/sapi/fpm/fpm/fastcgi.c
index 36e37b79d3..d2764a59b7 100644
--- a/sapi/fpm/fpm/fastcgi.c
+++ b/sapi/fpm/fpm/fastcgi.c
@@ -280,6 +280,10 @@ void fcgi_set_allowed_clients(char *ip)
}
allowed_clients[n].sa.sa_family = 0;
free(ip);
+ if (!n) {
+ zlog(ZLOG_ERROR, "There are no allowed addresses for this pool");
+ /* don't clear allowed_clients as it will create an "open for all" security issue */
+ }
}
}