diff options
| author | Greg Roach <fisharebest@gmail.com> | 2014-09-04 22:29:26 +0100 |
|---|---|---|
| committer | Ferenc Kovacs <tyrael@php.net> | 2015-01-02 10:14:12 +0100 |
| commit | 244fc1e05367dc7ebdf2db260c8bc8b106563d26 (patch) | |
| tree | 4713a165cf9fbaec25e78b3b93e848587197a7e2 | |
| parent | 99162b8198b37b5fa434152e472099379bf1f55c (diff) | |
| download | php-git-244fc1e05367dc7ebdf2db260c8bc8b106563d26.tar.gz | |
Fixes #67960 - Long/short day names reversed in jddayofweek()
| -rw-r--r-- | ext/calendar/calendar.c | 6 | ||||
| -rw-r--r-- | ext/calendar/tests/jddayofweek.phpt | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/ext/calendar/calendar.c b/ext/calendar/calendar.c index 34b34da371..7ef03f060f 100644 --- a/ext/calendar/calendar.c +++ b/ext/calendar/calendar.c @@ -208,7 +208,7 @@ static struct cal_entry_t cal_conversion_table[CAL_NUM_CALS] = { #define JEWISH_HEB_MONTH_NAME(year) ((monthsPerYear[((year)-1) % 19] == 13)?JewishMonthHebNameLeap:JewishMonthHebName) /* For jddayofweek */ -enum { CAL_DOW_DAYNO, CAL_DOW_SHORT, CAL_DOW_LONG }; +enum { CAL_DOW_DAYNO, CAL_DOW_LONG, CAL_DOW_SHORT }; /* For jdmonthname */ enum { CAL_MONTH_GREGORIAN_SHORT, CAL_MONTH_GREGORIAN_LONG, @@ -696,10 +696,10 @@ PHP_FUNCTION(jddayofweek) daynames = DayNameShort[day]; switch (mode) { - case CAL_DOW_SHORT: + case CAL_DOW_LONG: RETURN_STRING(daynamel, 1); break; - case CAL_DOW_LONG: + case CAL_DOW_SHORT: RETURN_STRING(daynames, 1); break; case CAL_DOW_DAYNO: diff --git a/ext/calendar/tests/jddayofweek.phpt b/ext/calendar/tests/jddayofweek.phpt index c33d59892d..c5647804bb 100644 --- a/ext/calendar/tests/jddayofweek.phpt +++ b/ext/calendar/tests/jddayofweek.phpt @@ -6,7 +6,7 @@ jddayofweek() <?php foreach (array(2440588, 2452162, 2453926, -1000) as $jd) { echo "### JD $jd ###\n"; - for ($mode = 0; $mode <= 2; $mode++) { + foreach (array(CAL_DOW_DAYNO, CAL_DOW_LONG, CAL_DOW_SHORT) as $mode) { echo "--- mode $mode ---\n"; for ($offset = 0; $offset <= 7; $offset++) { echo jddayofweek($jd + $offset, $mode). "\n"; |