summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXinchen Hui <laruence@php.net>2015-02-14 22:20:33 +0800
committerXinchen Hui <laruence@php.net>2015-02-14 22:20:33 +0800
commite017f35b7f91d9be6e8f937a81c21d9b0d30825b (patch)
tree4f3e48d31687c21c2ddf39eacfea6acac99dd940
parentb73fa1fa8fdddb069ffa9f07e1362b29edf51162 (diff)
parent1db720cd6d63f5feafb5c7ecc5fada35e2189cff (diff)
downloadphp-git-e017f35b7f91d9be6e8f937a81c21d9b0d30825b.tar.gz
Merge branch 'PHP-5.6'
Conflicts: ext/pgsql/pgsql.c
-rw-r--r--ext/pgsql/pgsql.c10
-rw-r--r--ext/pgsql/tests/bug68638.phpt53
2 files changed, 59 insertions, 4 deletions
diff --git a/ext/pgsql/pgsql.c b/ext/pgsql/pgsql.c
index ea1a314395..e27bd22eca 100644
--- a/ext/pgsql/pgsql.c
+++ b/ext/pgsql/pgsql.c
@@ -5746,9 +5746,6 @@ static int php_pgsql_convert_match(const char *str, size_t str_len, const char *
regerr = regexec(&re, str, re.re_nsub+1, subs, 0);
if (regerr == REG_NOMATCH) {
-#ifdef PHP_DEBUG
- php_error_docref(NULL, E_NOTICE, "'%s' does not match with '%s'", str, regex);
-#endif
ret = FAILURE;
}
else if (regerr) {
@@ -5987,7 +5984,12 @@ PHP_PGSQL_API int php_pgsql_convert(PGconn *pg_link, const char *table_name, con
else {
/* better regex? */
if (php_pgsql_convert_match(Z_STRVAL_P(val), Z_STRLEN_P(val), "^[-+]?[0-9]*\\.?[0-9]+([eE][-+]?[0-9]+)?$", 0) == FAILURE) {
- err = 1;
+ if (php_pgsql_convert_match(Z_STRVAL_P(val), Z_STRLEN_P(val), "^[+-]{0,1}(inf)(inity){0,1}$", 1) == FAILURE) {
+ err = 1;
+ } else {
+ ZVAL_STRING(&new_val, Z_STRVAL_P(val));
+ php_pgsql_add_quotes(&new_val, 1);
+ }
}
else {
ZVAL_STRING(&new_val, Z_STRVAL_P(val));
diff --git a/ext/pgsql/tests/bug68638.phpt b/ext/pgsql/tests/bug68638.phpt
new file mode 100644
index 0000000000..e0701a79f5
--- /dev/null
+++ b/ext/pgsql/tests/bug68638.phpt
@@ -0,0 +1,53 @@
+--TEST--
+Bug #68638 pg_update() fails to store infinite values
+--SKIPIF--
+<?php include("skipif.inc"); ?>
+--FILE--
+<?php
+
+include('config.inc');
+
+$conn = pg_connect($conn_str);
+
+$table='test_68638';
+
+pg_query("CREATE TABLE $table (id INT, value FLOAT)");
+
+pg_insert($conn,$table, array('id' => 1, 'value' => 1.2));
+pg_insert($conn,$table, array('id' => 2, 'value' => 10));
+pg_insert($conn,$table, array('id' => 3, 'value' => 15));
+
+var_dump(pg_update($conn,$table, array('value' => 'inf'), array('id' => 1), PGSQL_DML_STRING));
+
+pg_update($conn,$table, array('value' => 'inf'), array('id' => 1));
+pg_update($conn,$table, array('value' => '-inf'), array('id' => 2));
+pg_update($conn,$table, array('value' => '+inf'), array('id' => 3));
+
+$rs = pg_query("SELECT * FROM $table");
+while ($row = pg_fetch_assoc($rs)) {
+ var_dump($row);
+}
+
+pg_query("DROP TABLE $table");
+
+?>
+--EXPECT--
+string(52) "UPDATE "test_68638" SET "value"=E'inf' WHERE "id"=1;"
+array(2) {
+ ["id"]=>
+ string(1) "1"
+ ["value"]=>
+ string(8) "Infinity"
+}
+array(2) {
+ ["id"]=>
+ string(1) "2"
+ ["value"]=>
+ string(9) "-Infinity"
+}
+array(2) {
+ ["id"]=>
+ string(1) "3"
+ ["value"]=>
+ string(8) "Infinity"
+}