diff options
| author | Christoph M. Becker <cmbecker69@gmx.de> | 2016-09-11 18:29:27 +0200 |
|---|---|---|
| committer | Christoph M. Becker <cmbecker69@gmx.de> | 2016-09-11 18:29:27 +0200 |
| commit | 38455293f740e0444d16a247dc06db8d8ca18581 (patch) | |
| tree | feb6f7f311cd917c3435d2f1debb3d2100a3a975 | |
| parent | dc09f309335cf8df7d39adc03580ac8d4f0c78f5 (diff) | |
| download | php-git-38455293f740e0444d16a247dc06db8d8ca18581.tar.gz | |
Make test case more resilient
This test case fails with external libgd, because libgd < 2.2.4 converts
palette images to truecolor (<https://github.com/libgd/libgd/issues/297>).
However, even if there happens no truecolor conversion, it is not guaranteed
that the palette indexes of the original and the cropped image are identical
(this is, for instance, not the case with current libgd master where the bug
has been fixed). Therefore we check for the expected RGBA value instead of
the palette index.
| -rw-r--r-- | ext/gd/tests/bug67447.phpt | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/ext/gd/tests/bug67447.phpt b/ext/gd/tests/bug67447.phpt index 878b322689..c17454433d 100644 --- a/ext/gd/tests/bug67447.phpt +++ b/ext/gd/tests/bug67447.phpt @@ -23,10 +23,19 @@ imagecolorallocate($image, 0, 0, 255); // first palette color = background $red = imagecolorallocate($image, 255, 0, 0); imagefill($image, 0, 0, $red); $cropped = imagecrop($image, ['x' => 0, 'y' => 0, 'width' => 250, 'height' => 250]); -var_dump(imagecolorat($cropped, 249, 249) === $red); +var_dump(imagecolorsforindex($cropped, imagecolorat($cropped, 249, 249))); imagedestroy($image); imagedestroy($cropped); ?> --EXPECT-- bool(true) -bool(true) +array(4) { + ["red"]=> + int(255) + ["green"]=> + int(0) + ["blue"]=> + int(0) + ["alpha"]=> + int(0) +} |