summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristopher Jones <sixd@php.net>2018-09-24 20:52:58 +1000
committerChristopher Jones <sixd@php.net>2018-09-24 20:52:58 +1000
commit9e56a3373e88c6e147a5e11acddf134d2d3209ba (patch)
tree5965763f6ad60a10da2a19d52d658f8d2483cacd
parent91954c24da379946786e21e10f2a5d1a3306f64f (diff)
downloadphp-git-9e56a3373e88c6e147a5e11acddf134d2d3209ba.tar.gz
Terminate smart string correctly
This is related to Zend VM regression bug #75881. The regression was fixed in the VM, so there is no user visible change from the termination correction.
-rw-r--r--ext/oci8/oci8.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/ext/oci8/oci8.c b/ext/oci8/oci8.c
index 63fb334c99..aac2484d3e 100644
--- a/ext/oci8/oci8.c
+++ b/ext/oci8/oci8.c
@@ -1788,12 +1788,12 @@ php_oci_connection *php_oci_do_connect_ex(char *username, int username_len, char
timestamp = time(NULL);
smart_str_append_unsigned_ex(&hashed_details, session_mode, 0);
- smart_str_0(&hashed_details);
-
if (persistent) {
smart_str_appendl_ex(&hashed_details, "pc", sizeof("pc") - 1, 0);
}
+ smart_str_0(&hashed_details);
+
/* make it lowercase */
php_strtolower(ZSTR_VAL(hashed_details.s), ZSTR_LEN(hashed_details.s));