summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStanislav Malyshev <stas@php.net>2018-12-29 20:06:08 -0800
committerStanislav Malyshev <stas@php.net>2019-01-06 11:33:54 -0800
commit28362ed4fae6969b5a8878591a5a06eadf114e03 (patch)
treede1ea26fae1c5ff03f326544ae2e4f246714019f
parent20407d06ca3cb5eeb10f876a812b40c381574bcc (diff)
downloadphp-git-28362ed4fae6969b5a8878591a5a06eadf114e03.tar.gz
Fix bug #77371 (heap buffer overflow in mb regex functions - compile_string_node)
-rw-r--r--ext/mbstring/oniguruma/regcomp.c1
-rw-r--r--ext/mbstring/tests/bug77371.phpt10
2 files changed, 11 insertions, 0 deletions
diff --git a/ext/mbstring/oniguruma/regcomp.c b/ext/mbstring/oniguruma/regcomp.c
index 995e1d8861..4469f33a56 100644
--- a/ext/mbstring/oniguruma/regcomp.c
+++ b/ext/mbstring/oniguruma/regcomp.c
@@ -524,6 +524,7 @@ compile_string_node(Node* node, regex_t* reg)
for (; p < end; ) {
len = enclen(enc, p);
+ if (p + len > end) len = end - p;
if (len == prev_len) {
slen++;
}
diff --git a/ext/mbstring/tests/bug77371.phpt b/ext/mbstring/tests/bug77371.phpt
new file mode 100644
index 0000000000..f23445bd09
--- /dev/null
+++ b/ext/mbstring/tests/bug77371.phpt
@@ -0,0 +1,10 @@
+--TEST--
+Bug #77371 (heap buffer overflow in mb regex functions - compile_string_node)
+--SKIPIF--
+<?php extension_loaded('mbstring') or die('skip mbstring not available'); ?>
+--FILE--
+<?php
+var_dump(mb_ereg("()0\xfc00000\xfc00000\xfc00000\xfc",""))
+?>
+--EXPECT--
+bool(false) \ No newline at end of file