summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristoph M. Becker <cmbecker69@gmx.de>2020-07-22 20:45:55 +0200
committerChristoph M. Becker <cmbecker69@gmx.de>2020-07-22 20:45:56 +0200
commit6b99a8be4d3adef95eece9e84395966694bb1cec (patch)
tree7e7666cc85dd400586d7c53795deec4e48f7844d
parent2c0a6977ddd1c1306cd9b543c86dc90bb58013f0 (diff)
downloadphp-git-6b99a8be4d3adef95eece9e84395966694bb1cec.tar.gz
Fix brittle test
This test fails occasionally due to timing issues, because the session file may have been unlinked by the first `session_start()`'s GC. We adapt the test expectation to this reality.
-rw-r--r--ext/session/tests/session_module_name_variation4.phpt13
1 files changed, 4 insertions, 9 deletions
diff --git a/ext/session/tests/session_module_name_variation4.phpt b/ext/session/tests/session_module_name_variation4.phpt
index 00e6975045..3ac731835f 100644
--- a/ext/session/tests/session_module_name_variation4.phpt
+++ b/ext/session/tests/session_module_name_variation4.phpt
@@ -29,10 +29,12 @@ $_SESSION["Blah"] = "Hello World!";
$_SESSION["Foo"] = FALSE;
$_SESSION["Guff"] = 1234567890;
var_dump($_SESSION);
+$oldsession = $_SESSION;
var_dump(session_write_close());
session_start();
-var_dump($_SESSION);
+// the session may have been GC'd or not; we accept either outcome
+var_dump($_SESSION === $oldsession || $_SESSION === []);
var_dump(session_destroy());
session_start();
var_dump($_SESSION);
@@ -51,14 +53,7 @@ array(3) {
int(1234567890)
}
bool(true)
-array(3) {
- ["Blah"]=>
- string(12) "Hello World!"
- ["Foo"]=>
- bool(false)
- ["Guff"]=>
- int(1234567890)
-}
+bool(true)
bool(true)
array(0) {
}