diff options
author | Christoph M. Becker <cmbecker69@gmx.de> | 2019-05-09 16:55:35 +0200 |
---|---|---|
committer | Christoph M. Becker <cmbecker69@gmx.de> | 2019-05-09 16:55:35 +0200 |
commit | fd1ffa4692dd91af08ea019fc2db0d8b3835dfe9 (patch) | |
tree | c31f4ed408ceb0a93612b7e469450228983419f6 | |
parent | 90318fbcbed95e9f4469d697d47f76b9bd12e17f (diff) | |
parent | 27f168cf638183716d02ff1973856c8d5ef71273 (diff) | |
download | php-git-fd1ffa4692dd91af08ea019fc2db0d8b3835dfe9.tar.gz |
Merge branch 'PHP-7.2' into PHP-7.3
* PHP-7.2:
Fix erroneous assertions
-rw-r--r-- | win32/codepage.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/win32/codepage.c b/win32/codepage.c index 73645bc22b..b84909c10c 100644 --- a/win32/codepage.c +++ b/win32/codepage.c @@ -64,7 +64,7 @@ __forceinline static wchar_t *php_win32_cp_to_w_int(const char* in, size_t in_le } assert(ret ? tmp_len == ret_len : 1); - assert(ret ? wcslen(ret) == ret_len - 1 : 1); + assert(ret && !in_len ? wcslen(ret) == ret_len - 1 : 1); ret[ret_len-1] = L'\0'; @@ -103,7 +103,10 @@ PW32CP wchar_t *php_win32_cp_conv_ascii_to_w(const char* in, size_t in_len, size {/*{{{*/ wchar_t *ret, *ret_idx; const char *idx = in, *end; - +#if PHP_DEBUG + size_t save_in_len = in_len; +#endif + assert(in && in_len ? in[in_len] == '\0' : 1); if (!in) { @@ -195,7 +198,7 @@ PW32CP wchar_t *php_win32_cp_conv_ascii_to_w(const char* in, size_t in_len, size ret[in_len] = L'\0'; - assert(ret ? wcslen(ret) == in_len : 1); + assert(ret && !save_in_len ? wcslen(ret) == in_len : 1); if (PHP_WIN32_CP_IGNORE_LEN_P != out_len) { *out_len = in_len; @@ -239,7 +242,7 @@ __forceinline static char *php_win32_cp_from_w_int(const wchar_t* in, size_t in_ } assert(target ? r == target_len : 1); - assert(target ? strlen(target) == target_len - 1 : 1); + assert(target && !in_len ? strlen(target) == target_len - 1 : 1); target[target_len-1] = '\0'; |