diff options
| author | Stanislav Malyshev <stas@php.net> | 2020-03-15 17:26:00 -0700 |
|---|---|---|
| committer | Derick Rethans <github@derickrethans.nl> | 2020-03-17 09:47:14 +0000 |
| commit | 0c77b4307df73217283a4aaf9313e1a33a0967ff (patch) | |
| tree | d5673770ef92f0ce48f67d3eeca34dcea4e4219c | |
| parent | 54bccd7345b1f95cce2554362f761ba5f0afa24c (diff) | |
| download | php-git-0c77b4307df73217283a4aaf9313e1a33a0967ff.tar.gz | |
Fixed bug #79282
| -rw-r--r-- | ext/exif/exif.c | 7 | ||||
| -rw-r--r-- | ext/exif/tests/bug79282.phpt | 15 |
2 files changed, 21 insertions, 1 deletions
diff --git a/ext/exif/exif.c b/ext/exif/exif.c index 7bdf2acf1e..2dee5cdffe 100644 --- a/ext/exif/exif.c +++ b/ext/exif/exif.c @@ -3677,6 +3677,11 @@ static void exif_process_TIFF_in_JPEG(image_info_type *ImageInfo, char *CharBuf, { unsigned exif_value_2a, offset_of_ifd; + if (length < 2) { + exif_error_docref(NULL EXIFERR_CC, ImageInfo, E_WARNING, "Missing TIFF alignment marker"); + return; + } + /* set the thumbnail stuff to nothing so we can test to see if they get set up */ if (memcmp(CharBuf, "II", 2) == 0) { ImageInfo->motorola_intel = 0; @@ -3829,7 +3834,7 @@ static int exif_scan_JPEG_header(image_info_type *ImageInfo) return FALSE; } - sn = exif_file_sections_add(ImageInfo, marker, itemlen+1, NULL); + sn = exif_file_sections_add(ImageInfo, marker, itemlen, NULL); Data = ImageInfo->file.list[sn].data; /* Store first two pre-read bytes. */ diff --git a/ext/exif/tests/bug79282.phpt b/ext/exif/tests/bug79282.phpt new file mode 100644 index 0000000000..7b7e365657 --- /dev/null +++ b/ext/exif/tests/bug79282.phpt @@ -0,0 +1,15 @@ +--TEST-- +Bug #79282: Use-of-uninitialized-value in exif +--FILE-- +<?php + +var_dump(exif_read_data('data://image/jpeg;base64,/9jhAAlFeGlmAAAg')); + +?> +--EXPECTF-- +Warning: exif_read_data(): Invalid TIFF alignment marker in %s on line %d + +Warning: exif_read_data(): File structure corrupted in %s on line %d + +Warning: exif_read_data(): Invalid JPEG file in %s on line %d +bool(false) |