diff options
| author | Nikita Popov <nikita.ppv@gmail.com> | 2020-04-20 16:35:52 +0200 |
|---|---|---|
| committer | Nikita Popov <nikita.ppv@gmail.com> | 2020-04-20 16:35:52 +0200 |
| commit | 3e9dac2c6b5d69528ff5ef22ef7770c7532aa8cc (patch) | |
| tree | 039f129c9b6477bde14ab9505119075e9a31bb43 | |
| parent | 5c404915679015b828c036e22db5de096d1cff50 (diff) | |
| download | php-git-3e9dac2c6b5d69528ff5ef22ef7770c7532aa8cc.tar.gz | |
Don't rand() in test
Instead use port 0 to get a free port from the OS.
| -rw-r--r-- | ext/sockets/tests/socket_connect_params.phpt | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/ext/sockets/tests/socket_connect_params.phpt b/ext/sockets/tests/socket_connect_params.phpt index 94c38de1cb..45ff56d031 100644 --- a/ext/sockets/tests/socket_connect_params.phpt +++ b/ext/sockets/tests/socket_connect_params.phpt @@ -11,15 +11,17 @@ fa@php.net ?> --FILE-- <?php - $rand = rand(1,999); - $s_c = socket_create_listen(31330+$rand); - // wrong parameter count - $s_w = socket_connect(); - $s_w = socket_connect($s_c); - $s_w = socket_connect($s_c, '0.0.0.0'); - $s_w = socket_connect($s_c, '0.0.0.0', 31330+$rand); - socket_close($s_c); +$s_c = socket_create_listen(0); +socket_getsockname($s_c, $addr, $port); + +// wrong parameter count +$s_w = socket_connect(); +$s_w = socket_connect($s_c); +$s_w = socket_connect($s_c, '0.0.0.0'); +$s_w = socket_connect($s_c, '0.0.0.0', $port); + +socket_close($s_c); ?> --EXPECTF-- |