diff options
| author | Christoph M. Becker <cmbecker69@gmx.de> | 2021-01-02 12:18:46 +0100 |
|---|---|---|
| committer | Christoph M. Becker <cmbecker69@gmx.de> | 2021-01-03 16:12:10 +0100 |
| commit | e470f9b389313f2c966a87445c8e776c1897f532 (patch) | |
| tree | abc8a9463f75d90c8cae82f66153d55a68a841e0 | |
| parent | cae0bcbab53aa1011e1e54b368a1394b9a2066b7 (diff) | |
| download | php-git-e470f9b389313f2c966a87445c8e776c1897f532.tar.gz | |
ZipArchive methods do not return NULL
Closes GH-6563.
| -rw-r--r-- | ext/zip/php_zip.c | 4 | ||||
| -rw-r--r-- | ext/zip/php_zip.stub.php | 8 | ||||
| -rw-r--r-- | ext/zip/php_zip_arginfo.h | 2 |
3 files changed, 7 insertions, 7 deletions
diff --git a/ext/zip/php_zip.c b/ext/zip/php_zip.c index 92272d270f..6875850687 100644 --- a/ext/zip/php_zip.c +++ b/ext/zip/php_zip.c @@ -2449,7 +2449,7 @@ PHP_METHOD(ZipArchive, setMtimeName) if (zend_parse_parameters(ZEND_NUM_ARGS(), "sl|l", &name, &name_len, &mtime, &flags) == FAILURE) { - return; + RETURN_THROWS(); } ZIP_FROM_OBJECT(intern, this); @@ -2483,7 +2483,7 @@ PHP_METHOD(ZipArchive, setMtimeIndex) if (zend_parse_parameters(ZEND_NUM_ARGS(), "ll|l", &index, &mtime, &flags) == FAILURE) { - return; + RETURN_THROWS(); } ZIP_FROM_OBJECT(intern, this); diff --git a/ext/zip/php_zip.stub.php b/ext/zip/php_zip.stub.php index 9a276a05df..ddda62d6b0 100644 --- a/ext/zip/php_zip.stub.php +++ b/ext/zip/php_zip.stub.php @@ -111,17 +111,17 @@ class ZipArchive /** @return string|false */ public function getArchiveComment(int $flags = 0) {} - /** @return bool|null */ + /** @return bool */ public function setCommentIndex(int $index, string $comment) {} - /** @return bool|null */ + /** @return bool */ public function setCommentName(string $name, string $comment) {} #ifdef HAVE_SET_MTIME - /** @return bool|null */ + /** @return bool */ public function setMtimeIndex(int $index, int $timestamp, int $flags = 0) {} - /** @return bool|null */ + /** @return bool */ public function setMtimeName(string $name, int $timestamp, int $flags = 0) {} #endif diff --git a/ext/zip/php_zip_arginfo.h b/ext/zip/php_zip_arginfo.h index a4167fa8ca..87212a4975 100644 --- a/ext/zip/php_zip_arginfo.h +++ b/ext/zip/php_zip_arginfo.h @@ -1,5 +1,5 @@ /* This is a generated file, edit the .stub.php file instead. - * Stub hash: 4ca2b108e71924309abcdc1a0f86f5963a8516f3 */ + * Stub hash: 8994595a1c86072629e051291e87cc5e1774eb7f */ ZEND_BEGIN_ARG_INFO_EX(arginfo_zip_open, 0, 0, 1) ZEND_ARG_TYPE_INFO(0, filename, IS_STRING, 0) |