diff options
| author | Antony Dovgal <tony2001@php.net> | 2007-04-08 08:02:02 +0000 |
|---|---|---|
| committer | Antony Dovgal <tony2001@php.net> | 2007-04-08 08:02:02 +0000 |
| commit | 8bb69d5e0d04112cf199cd1c0a8d8d1eb2a50716 (patch) | |
| tree | 1e1dad37ed469f0b826c7680fee4aec3e05ff837 | |
| parent | c3b395d83adbec27d00bd686a2072cf626d263e2 (diff) | |
| download | php-git-8bb69d5e0d04112cf199cd1c0a8d8d1eb2a50716.tar.gz | |
MFB: Avoid locks when appening to the error log file
| -rw-r--r-- | main/main.c | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/main/main.c b/main/main.c index 9f2a276908..e2899d112f 100644 --- a/main/main.c +++ b/main/main.c @@ -27,6 +27,7 @@ #include "php.h" #include <stdio.h> +#include <fcntl.h> #ifdef PHP_WIN32 #include "win32/time.h" #include "win32/signal.h" @@ -440,7 +441,7 @@ static int module_shutdown = 0; */ PHPAPI void php_log_err(char *log_message TSRMLS_DC) { - FILE *log_file; + int fd = -1; char error_time_str[128]; struct tm tmbuf; time_t error_time; @@ -453,14 +454,16 @@ PHPAPI void php_log_err(char *log_message TSRMLS_DC) return; } #endif - log_file = VCWD_FOPEN(PG(error_log), "ab"); - if (log_file != NULL) { + fd = VCWD_OPEN_MODE(PG(error_log), O_CREAT | O_APPEND | O_WRONLY, 0644); + if (fd != -1) { + char *tmp; + int len; time(&error_time); strftime(error_time_str, sizeof(error_time_str), "%d-%b-%Y %H:%M:%S", php_localtime_r(&error_time, &tmbuf)); - fprintf(log_file, "[%s] ", error_time_str); - fprintf(log_file, "%s", log_message); - fprintf(log_file, "%s", PHP_EOL); - fclose(log_file); + len = spprintf(&tmp, 0, "[%s] %s%s", error_time_str, log_message, PHP_EOL); + write(fd, tmp, len); + efree(tmp); + close(fd); return; } } |