diff options
| author | Derick Rethans <derick@php.net> | 2007-09-06 13:28:05 +0000 |
|---|---|---|
| committer | Derick Rethans <derick@php.net> | 2007-09-06 13:28:05 +0000 |
| commit | e280715150e01edabae3ae43edb710ab55987a83 (patch) | |
| tree | f0d681c53df2c0eefeaa7bcc486d00ac4093109a | |
| parent | 09fbf87a6c8cedb18e6fc5b0e8acaf3f1ac9af89 (diff) | |
| download | php-git-e280715150e01edabae3ae43edb710ab55987a83.tar.gz | |
- MFH: Add a comment why not ~0 or -1.
| -rw-r--r-- | ext/standard/basic_functions.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/ext/standard/basic_functions.c b/ext/standard/basic_functions.c index 5014f9fcb2..a063bfab1f 100644 --- a/ext/standard/basic_functions.c +++ b/ext/standard/basic_functions.c @@ -4336,7 +4336,8 @@ PHP_FUNCTION(ip2long) if (Z_STRLEN_PP(str) == 0 || (ip = inet_addr(Z_STRVAL_PP(str))) == INADDR_NONE) { /* the only special case when we should return -1 ourselves, - * because inet_addr() considers it wrong. + * because inet_addr() considers it wrong. We return 0xFFFFFFFF and + * not -1 or ~0 because of 32/64bit issues. */ if (Z_STRLEN_PP(str) == sizeof("255.255.255.255") - 1 && !memcmp(Z_STRVAL_PP(str), "255.255.255.255", sizeof("255.255.255.255") - 1)) { |