summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDerick Rethans <derick@php.net>2008-02-22 17:49:30 +0000
committerDerick Rethans <derick@php.net>2008-02-22 17:49:30 +0000
commit8241ee2226a6083442f554c430537cc0d89b863c (patch)
tree981296f1cfa100bff80dbfb912d2d1eb2c350bf2
parentdfd8f3f735d222b6ea804644d52f0dbff51706b9 (diff)
downloadphp-git-8241ee2226a6083442f554c430537cc0d89b863c.tar.gz
- MFH: Fixed bug #44216 (strftime segfaults on large negative value).
-rw-r--r--NEWS1
-rw-r--r--ext/date/lib/dow.c6
2 files changed, 5 insertions, 2 deletions
diff --git a/NEWS b/NEWS
index 557776462d..20702f6671 100644
--- a/NEWS
+++ b/NEWS
@@ -11,6 +11,7 @@ PHP NEWS
- Upgraded PCRE to version 7.6 (Nuno)
+- Fixed bug #44216 (strftime segfaults on large negative value). (Derick)
- Fixed bug #44209 (strtotime() doesn't support 64 bit timestamps on 64 bit
platforms). (Derick)
- Fixed bug #44197 (socket array keys lost on socket_select). (Felipe)
diff --git a/ext/date/lib/dow.c b/ext/date/lib/dow.c
index 876c7dfcb2..def1b3e59e 100644
--- a/ext/date/lib/dow.c
+++ b/ext/date/lib/dow.c
@@ -35,10 +35,12 @@ static timelib_sll timelib_day_of_week_ex(timelib_sll y, timelib_sll m, timelib_
{
timelib_sll c1, y1, m1, dow;
- /* Only valid for Gregorian calendar */
+ /* Only valid for Gregorian calendar, commented out as we don't handle
+ * julian calendar. We just return the 'wrong' day of week to be
+ * consistent.
if (y < 1753) {
return -1;
- }
+ } */
c1 = century_value(y / 100);
y1 = (y % 100);
m1 = timelib_is_leap(y) ? m_table_leap[m] : m_table_common[m];