diff options
| author | Remi Collet <remi@php.net> | 2014-03-12 15:33:41 +0100 |
|---|---|---|
| committer | Remi Collet <remi@php.net> | 2014-03-12 15:35:42 +0100 |
| commit | f2d5b2b6c657db29af3bc92d93645ff66574b56f (patch) | |
| tree | 4f139b98cb4ab95992cd6dd467c22ec01cdcdf50 | |
| parent | 06bbb657ad8ae4660051da1ad698370f0c06bdc4 (diff) | |
| download | php-git-f2d5b2b6c657db29af3bc92d93645ff66574b56f.tar.gz | |
Fixed Bug #66893i imagescale ignore method argument
We also have our goto fail; bug.
Upstream fix for libgd
https://bitbucket.org/libgd/gd-libgd/commits/5b42b1178c37ffd30c9a15733058656be0277da0
| -rw-r--r-- | ext/gd/gd.c | 28 | ||||
| -rw-r--r-- | ext/gd/libgd/gd_interpolation.c | 5 |
2 files changed, 5 insertions, 28 deletions
diff --git a/ext/gd/gd.c b/ext/gd/gd.c index 1b8366d58c..90a053535a 100644 --- a/ext/gd/gd.c +++ b/ext/gd/gd.c @@ -5101,7 +5101,7 @@ PHP_FUNCTION(imagescale) { zval *IM; gdImagePtr im; - gdImagePtr im_scaled; + gdImagePtr im_scaled = NULL; int new_width, new_height; long tmp_w, tmp_h=-1, tmp_m = GD_BILINEAR_FIXED; gdInterpolationMethod method; @@ -5114,31 +5114,11 @@ PHP_FUNCTION(imagescale) new_height = tmp_h; ZEND_FETCH_RESOURCE(im, gdImagePtr, &IM, -1, "Image", le_gd); - im_scaled = gdImageScale(im, new_width, new_height); - goto finish; - switch (method) { - case GD_NEAREST_NEIGHBOUR: - im_scaled = gdImageScaleNearestNeighbour(im, new_width, new_height); - break; - - case GD_BILINEAR_FIXED: - im_scaled = gdImageScaleBilinear(im, new_width, new_height); - break; - - case GD_BICUBIC: - im_scaled = gdImageScaleBicubicFixed(im, new_width, new_height); - break; - - case GD_BICUBIC_FIXED: - im_scaled = gdImageScaleBicubicFixed(im, new_width, new_height); - break; - - default: - im_scaled = gdImageScaleTwoPass(im, im->sx, im->sy, new_width, new_height); - break; + if (gdImageSetInterpolationMethod(im, method)) { + im_scaled = gdImageScale(im, new_width, new_height); } -finish: + if (im_scaled == NULL) { RETURN_FALSE; } else { diff --git a/ext/gd/libgd/gd_interpolation.c b/ext/gd/libgd/gd_interpolation.c index 3643535f2e..76327be7df 100644 --- a/ext/gd/libgd/gd_interpolation.c +++ b/ext/gd/libgd/gd_interpolation.c @@ -2472,10 +2472,7 @@ int gdImageSetInterpolationMethod(gdImagePtr im, gdInterpolationMethod id) switch (id) { case GD_DEFAULT: - im->interpolation_id = GD_BILINEAR_FIXED; - im->interpolation = NULL; - break; - + id = GD_BILINEAR_FIXED; /* Optimized versions */ case GD_BILINEAR_FIXED: case GD_BICUBIC_FIXED: |