diff options
| author | Anatol Belski <ab@php.net> | 2017-07-08 23:52:22 +0200 |
|---|---|---|
| committer | Anatol Belski <ab@php.net> | 2017-07-08 23:52:22 +0200 |
| commit | b5338c0b7d145d9b5b5abcb9d695691ca5d6e418 (patch) | |
| tree | 1a63ce41b26ac0ab20f89dc610e8ae7c6cea37ee | |
| parent | 0fdceb6cd5eb4cc71eac68ca1a2037c32844a0f6 (diff) | |
| download | php-git-b5338c0b7d145d9b5b5abcb9d695691ca5d6e418.tar.gz | |
Fixed bug #74883 SQLite3::__construct() produces "out of memory" exception with invalid flags
| -rw-r--r-- | ext/sqlite3/sqlite3.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/ext/sqlite3/sqlite3.c b/ext/sqlite3/sqlite3.c index e3322ddfe8..dcbc03cf84 100644 --- a/ext/sqlite3/sqlite3.c +++ b/ext/sqlite3/sqlite3.c @@ -103,6 +103,7 @@ PHP_METHOD(sqlite3, open) char *filename, *encryption_key, *fullpath; size_t filename_len, encryption_key_len = 0; zend_long flags = SQLITE_OPEN_READWRITE | SQLITE_OPEN_CREATE; + int rc; db_obj = Z_SQLITE3_DB_P(object); @@ -141,11 +142,13 @@ PHP_METHOD(sqlite3, open) } #if SQLITE_VERSION_NUMBER >= 3005000 - if (sqlite3_open_v2(fullpath, &(db_obj->db), flags, NULL) != SQLITE_OK) { + rc = sqlite3_open_v2(fullpath, &(db_obj->db), flags, NULL); #else - if (sqlite3_open(fullpath, &(db_obj->db)) != SQLITE_OK) { + rc = sqlite3_open(fullpath, &(db_obj->db)); #endif - zend_throw_exception_ex(zend_ce_exception, 0, "Unable to open database: %s", sqlite3_errmsg(db_obj->db)); + if (rc != SQLITE_OK) { + zend_throw_exception_ex(zend_ce_exception, 0, "Unable to open database: %s", + db_obj->db ? sqlite3_errmsg(db_obj->db) : sqlite3_errstr(rc)); if (fullpath != filename) { efree(fullpath); } |