summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristoph M. Becker <cmbecker69@gmx.de>2018-10-16 18:50:33 +0200
committerChristoph M. Becker <cmbecker69@gmx.de>2018-10-16 18:50:58 +0200
commit181fc483ed64a77d931a86dd61ed2006f44006c7 (patch)
treea60aefab173b0bcc37179ff4dcbac04da3f51ba5
parent6b8605d31f7f4b099a2a79d3d9bf0bcd607472af (diff)
parent310b95d7eb1d10723d6bc4fa4781a7d852100f1d (diff)
downloadphp-git-181fc483ed64a77d931a86dd61ed2006f44006c7.tar.gz
Merge branch 'PHP-7.2' into PHP-7.3
* PHP-7.2: Add support for getting SKIP_TAGSTART and SKIP_WHITE options
-rw-r--r--NEWS1
-rw-r--r--ext/xml/tests/xml_parser_get_option_variation3.phpt29
-rw-r--r--ext/xml/xml.c6
3 files changed, 36 insertions, 0 deletions
diff --git a/NEWS b/NEWS
index 836fdde2cc..e029cdaaf7 100644
--- a/NEWS
+++ b/NEWS
@@ -17,6 +17,7 @@ PHP NEWS
- XML:
. Fixed bug #30875 (xml_parse_into_struct() does not resolve entities). (cmb)
+ . Add support for getting SKIP_TAGSTART and SKIP_WHITE options. (cmb)
11 Oct 2018, PHP 7.3.0RC3
diff --git a/ext/xml/tests/xml_parser_get_option_variation3.phpt b/ext/xml/tests/xml_parser_get_option_variation3.phpt
new file mode 100644
index 0000000000..839daa96dd
--- /dev/null
+++ b/ext/xml/tests/xml_parser_get_option_variation3.phpt
@@ -0,0 +1,29 @@
+--TEST--
+xml_parser_get_option() with XML_OPTION_SKIP_TAGSTART and XML_OPTION_SKIP_WHITE
+--SKIPIF--
+<?php
+if (!extension_loaded('xml')) die('skip xml extension not available');
+?>
+--FILE--
+<?php
+$parser = xml_parser_create();
+echo "defaults:\n";
+var_dump(xml_parser_get_option($parser, XML_OPTION_SKIP_TAGSTART));
+var_dump(xml_parser_get_option($parser, XML_OPTION_SKIP_WHITE));
+echo "setting:\n";
+var_dump(xml_parser_set_option($parser, XML_OPTION_SKIP_TAGSTART, 7));
+var_dump(xml_parser_set_option($parser, XML_OPTION_SKIP_WHITE, 1));
+echo "getting:\n";
+var_dump(xml_parser_get_option($parser, XML_OPTION_SKIP_TAGSTART));
+var_dump(xml_parser_get_option($parser, XML_OPTION_SKIP_WHITE));
+?>
+--EXPECT--
+defaults:
+int(0)
+int(0)
+setting:
+bool(true)
+bool(true)
+getting:
+int(7)
+int(1)
diff --git a/ext/xml/xml.c b/ext/xml/xml.c
index 3cacb31ad7..8a5f7797ce 100644
--- a/ext/xml/xml.c
+++ b/ext/xml/xml.c
@@ -1637,6 +1637,12 @@ PHP_FUNCTION(xml_parser_get_option)
case PHP_XML_OPTION_CASE_FOLDING:
RETURN_LONG(parser->case_folding);
break;
+ case PHP_XML_OPTION_SKIP_TAGSTART:
+ RETURN_LONG(parser->toffset);
+ break;
+ case PHP_XML_OPTION_SKIP_WHITE:
+ RETURN_LONG(parser->skipwhite);
+ break;
case PHP_XML_OPTION_TARGET_ENCODING:
RETURN_STRING((char *)parser->target_encoding);
break;