summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAdam Harvey <aharvey@php.net>2019-11-20 15:33:04 -0800
committerAdam Harvey <aharvey@php.net>2019-11-20 15:33:04 -0800
commit00df73c30db7b3ee77462a0628e633f3d6bdb0c6 (patch)
tree41801ec1f6fef83b02ded1b19df5974c1a98a1e9
parentbcb8ab304efab49489fdcb74094f7a7527194daa (diff)
downloadphp-git-00df73c30db7b3ee77462a0628e633f3d6bdb0c6.tar.gz
Make the UPGRADING note about ArrayObject more explicit.
We noticed the BC break when testing `curl_setopt()`, and hadn't interpreted this note as affecting internal functions in general, so this adds a sub-bullet to note that. This overlaps a bit with the previous bullet, but since I don't know exactly which operations were in mind at the time, I've elected to preserve them both. Bits are cheap.
-rw-r--r--UPGRADING3
1 files changed, 3 insertions, 0 deletions
diff --git a/UPGRADING b/UPGRADING
index 2a72976178..d9b46f2c38 100644
--- a/UPGRADING
+++ b/UPGRADING
@@ -120,6 +120,9 @@ PHP 7.4 UPGRADE NOTES
* ReflectionObject::getProperties()
* reset(), current(), etc. Use Iterator methods instead.
* Potentially others working on object properties as a list.
+ * Other internal functions that iterate over an array, but which
+ previously silently accepted an ArrayObject as well; eg curl_setopt()
+ when used with an option that expects an array.
(array) casts are *not* affected. They will continue to return either the
wrapped array, or the ArrayObject properties, depending on whether the