summaryrefslogtreecommitdiff
path: root/README.RELEASE_PROCESS
diff options
context:
space:
mode:
authorChristoph M. Becker <cmbecker69@gmx.de>2018-12-07 15:09:26 +0100
committerChristoph M. Becker <cmbecker69@gmx.de>2018-12-07 15:11:48 +0100
commit8f46f6dd6f3c3dcab1dbc4d8e56bf8b509901389 (patch)
tree4d728c799c40db63f739d5b2e5652c1a80e4bae0 /README.RELEASE_PROCESS
parentc4e9f6fc331316bb08c6cd377f02510b002a6483 (diff)
downloadphp-git-8f46f6dd6f3c3dcab1dbc4d8e56bf8b509901389.tar.gz
ZEND_VERSION should be in sync with PHP_VERSION and friends
While the major version is different, and the minor version may be different, the revision and the extra should always be synced, as recently discussed on the release manager's list. We add the respective info to README.RELEASE_PROCESS, to not forget about it in the future.
Diffstat (limited to 'README.RELEASE_PROCESS')
-rw-r--r--README.RELEASE_PROCESS8
1 files changed, 4 insertions, 4 deletions
diff --git a/README.RELEASE_PROCESS b/README.RELEASE_PROCESS
index 9cbc44fe37..58409f3e89 100644
--- a/README.RELEASE_PROCESS
+++ b/README.RELEASE_PROCESS
@@ -65,7 +65,7 @@ credits files in ext/standard.
4. Checkout the release branch for this release (e.g., PHP-5.4.2) from the main branch.
-5. Bump the version numbers in ``main/php_version.h``, ``configure.ac`` and possibly ``NEWS``.
+5. Bump the version numbers in ``main/php_version.h``, ``Zend/zend.h``, ``configure.ac`` and possibly ``NEWS``.
Do not use abbreviations for alpha and beta. Do not use dashes, you should
``#define PHP_VERSION "5.4.22RC1"`` and not ``#define PHP_VERSION "5.4.22-RC1"``
@@ -79,7 +79,7 @@ Do not use abbreviations for alpha and beta. Do not use dashes, you should
9. Tag the repository release branch with the version, e.g.:
``git tag -u YOURKEYID php-5.4.2RC2``
-10. Bump the version numbers in ``main/php_version.h``, ``configure.ac`` and ``NEWS``
+10. Bump the version numbers in ``main/php_version.h``, ``Zend/zend.h``, ``configure.ac`` and ``NEWS``
in the *main* branch (PHP-5.4 for example) to prepare for the **next** version.
F.e. if the RC is "5.4.1RC1" then the new one should be "5.4.2-dev" - regardless if we get
a new RC or not. This is to make sure ``version_compare()`` can correctly work.
@@ -159,7 +159,7 @@ Rolling a stable release
------------------------
1. Checkout your release branch, you should have created when releasing previous RC
-and bump the version numbers in ``main/php_version.h``, ``configure.ac`` and possibly ``NEWS``.
+and bump the version numbers in ``main/php_version.h``, ``Zend/zend.h``, ``configure.ac`` and possibly ``NEWS``.
2. If a CVE commit needs to be merged to the release, then have it committed to
the base branches and merged upwards as usual (f.e commit the CVE fix to 5.3,
@@ -381,7 +381,7 @@ New Release Manager Checklist
one or more of the previous RMs sign your key. Publish your public key to pgp.mit.edu with:
`gpg --keyserver pgp.mit.edu --send-keys $KEYID`
-3. Request karma to edit main/php_version.h. Possibly karma for other restricted parts of
+3. Request karma to edit main/php_version.h and Zend/zend.h. Possibly karma for other restricted parts of
php-src might come in question. To edit main/php_version.h in a release branch,
you need release manager karma in global_avail.