summaryrefslogtreecommitdiff
path: root/UPGRADING
diff options
context:
space:
mode:
authorGustavo André dos Santos Lopes <cataphract@php.net>2011-03-21 02:58:54 +0000
committerGustavo André dos Santos Lopes <cataphract@php.net>2011-03-21 02:58:54 +0000
commit7f2937223dec01f23e8bffb1824bee3420a703f2 (patch)
treef42f4443d59b5f5ae8dfd21a89acc93d80e985d0 /UPGRADING
parent2034e143410117ac0c85f46e724cc33ec80157eb (diff)
downloadphp-git-7f2937223dec01f23e8bffb1824bee3420a703f2.tar.gz
- Make fclose() actually close stream, even when the resource refcount is > 1.
This reverts the fix for bug #24557. - Make php_stream_free delete the stream from the resources list, not merely decrease its refcount, as a single call to zend_list_delete does. #Not worth the risk merging to 5.3. While change #2 may prevent some segfaults, #a quick and dirty survey to the codebase only showed calls to php_stream_close #or php_stream_free on streams allocated in the same function, which would have #refcount == 1. May be reconsidered.
Diffstat (limited to 'UPGRADING')
-rwxr-xr-xUPGRADING2
1 files changed, 2 insertions, 0 deletions
diff --git a/UPGRADING b/UPGRADING
index 69b58bb709..df170bb622 100755
--- a/UPGRADING
+++ b/UPGRADING
@@ -167,6 +167,8 @@ UPGRADE NOTES - PHP X.Y
- stream_set_write_buffer() no longer disables the read buffer of a plain
stream when 0 is given as the second argument.
- stream_set_write_buffer() no longer changes the chunk size in socket streams.
+- fclose() closes streams with resource refcount > 1; it doesn't merely
+ decrement the resource refcount.
===================================
5. Changes made to existing methods