diff options
| author | Nikita Popov <nikita.ppv@gmail.com> | 2019-10-31 11:27:53 +0100 |
|---|---|---|
| committer | Nikita Popov <nikita.ppv@gmail.com> | 2020-05-11 12:22:28 +0200 |
| commit | 5dc9418a97041e92d60a2682c243d219fc34f3a2 (patch) | |
| tree | f5425fec2d57c24d2a4a1d20fee405ade3886fee /build | |
| parent | a0abc26ef78da4209b937fefd0e94b2acf147cef (diff) | |
| download | php-git-5dc9418a97041e92d60a2682c243d219fc34f3a2.tar.gz | |
Reapply "Remove configure checks for supported instruction sets"
I reverted this previously for 7.4 because of bug #78769. Relanding
it now for master, because I still believe that this change is
right, and if it causes complications, those indicate a bug elsewhere.
---
These were checking whether the instruction set is supported by
the host CPU, however they were only used to condition on whether
this instruction set is targeted at all. It would still use dynamic
dispatch (e.g. based on ifunc resolvers) to select the actual
implementation. Whether the target is guaranteed to support the
instruction set without dispatch is determined based on pre-defined
macros like __SSE2__.
This removes the configure-time builtin cpu checks to remove
confusion. Additionally this allows targeting an architecture that
is newer than the host architecture.
Diffstat (limited to 'build')
| -rw-r--r-- | build/php.m4 | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/build/php.m4 b/build/php.m4 index 0ccd919344..e3548e7cfa 100644 --- a/build/php.m4 +++ b/build/php.m4 @@ -2670,30 +2670,6 @@ AC_DEFUN([PHP_CHECK_BUILTIN_CPU_SUPPORTS], [ ]) dnl -dnl PHP_CHECK_CPU_SUPPORTS -dnl -AC_DEFUN([PHP_CHECK_CPU_SUPPORTS], [ - AC_REQUIRE([PHP_CHECK_BUILTIN_CPU_INIT]) - AC_REQUIRE([PHP_CHECK_BUILTIN_CPU_SUPPORTS]) - have_ext_instructions=0 - if test $have_builtin_cpu_supports = 1; then - AC_MSG_CHECKING([for $1 instructions supports]) - AC_RUN_IFELSE([AC_LANG_SOURCE([[ -int main() { - return __builtin_cpu_supports("$1")? 0 : 1; -} - ]])], [ - have_ext_instructions=1 - AC_MSG_RESULT([yes]) - ], [ - AC_MSG_RESULT([no]) - ], [AC_MSG_RESULT([no])]) - fi - AC_DEFINE_UNQUOTED(AS_TR_CPP([PHP_HAVE_$1_INSTRUCTIONS]), - [$have_ext_instructions], [Whether the compiler supports $1 instructions]) -]) - -dnl dnl PHP_PATCH_CONFIG_HEADERS([FILE]) dnl dnl PACKAGE_* symbols are automatically defined by Autoconf. When including |