diff options
| author | Christoph M. Becker <cmbecker69@gmx.de> | 2020-02-14 10:55:17 +0100 |
|---|---|---|
| committer | Christoph M. Becker <cmbecker69@gmx.de> | 2020-02-17 09:07:54 +0100 |
| commit | 09669411309b5c18c48b550d89b34e78983118cd (patch) | |
| tree | b91a87e1a622db6b59415d098a6fd7d6a55832b5 /ext/dom/node.c | |
| parent | 392dada1d64e67508304482efb107c5932d995b0 (diff) | |
| download | php-git-09669411309b5c18c48b550d89b34e78983118cd.tar.gz | |
Fix #79271: DOMDocumentType::$childNodes is NULL
Dom level 2 core, DOM level 3 core and the DOM living standard agree
that `childNodes` always return a `NodeList`, and never `null`.
Diffstat (limited to 'ext/dom/node.c')
| -rw-r--r-- | ext/dom/node.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/ext/dom/node.c b/ext/dom/node.c index 0e7f64a9bd..7d939bcde1 100644 --- a/ext/dom/node.c +++ b/ext/dom/node.c @@ -428,13 +428,9 @@ int dom_node_child_nodes_read(dom_object *obj, zval *retval) return FAILURE; } - if (dom_node_children_valid(nodep) == FAILURE) { - ZVAL_NULL(retval); - } else { - php_dom_create_interator(retval, DOM_NODELIST); - intern = Z_DOMOBJ_P(retval); - dom_namednode_iter(obj, XML_ELEMENT_NODE, intern, NULL, NULL, NULL); - } + php_dom_create_interator(retval, DOM_NODELIST); + intern = Z_DOMOBJ_P(retval); + dom_namednode_iter(obj, XML_ELEMENT_NODE, intern, NULL, NULL, NULL); return SUCCESS; } |