summaryrefslogtreecommitdiff
path: root/ext/hash
diff options
context:
space:
mode:
authorChristoph M. Becker <cmbecker69@gmx.de>2016-10-18 14:56:20 +0200
committerChristoph M. Becker <cmbecker69@gmx.de>2016-10-18 14:57:41 +0200
commit35b19cd2d936fb8caa081496fb610e79c4bab003 (patch)
tree8c61786051d1c090590a0ba8df3171a07de22791 /ext/hash
parentb7fe687914759cae706e318c3a4c245c9f71400d (diff)
downloadphp-git-35b19cd2d936fb8caa081496fb610e79c4bab003.tar.gz
Make this test meaningful
We're not only checking that hash_update_file() succeeds, but rather that it properly works. Furthermore, we fix the SKIPIF section – we don't need mhash to run the test, and we don't need to check for unsupported PHP versions. We also shorten the test name to avoid cluttering the test reports with unnecessary detail.
Diffstat (limited to 'ext/hash')
-rw-r--r--ext/hash/tests/hash_update_file.phpt19
1 files changed, 11 insertions, 8 deletions
diff --git a/ext/hash/tests/hash_update_file.phpt b/ext/hash/tests/hash_update_file.phpt
index 32ce962bd0..488be47411 100644
--- a/ext/hash/tests/hash_update_file.phpt
+++ b/ext/hash/tests/hash_update_file.phpt
@@ -1,21 +1,24 @@
--TEST--
-bool hash_update_file ( resource $hcontext , string $filename [, resource $scontext = NULL ] );
+hash_update_file() function - basic test
--CREDITS--
marcosptf - <marcosptf@yahoo.com.br> - @phpsp - sao paulo - br
--SKIPIF--
<?php
-if (phpversion() < "5.3.0") {
- die('SKIP php version so lower.');
-}
-require_once(dirname(__FILE__) . '/skip_mhash.inc'); ?>
+if (!extension_loaded('hash')) die('skip hash extension not available');
?>
--FILE--
<?php
+$filePath = __DIR__ . DIRECTORY_SEPARATOR . 'hash_update_stream.txt';
+file_put_contents($filePath, 'The quick brown fox jumped over the lazy dog.');
+
$ctx = hash_init('md5');
-$filePath = __DIR__ . DIRECTORY_SEPARATOR . 'sha1.phpt';
-fopen($filePath, "r");
var_dump(hash_update_file($ctx, $filePath));
-hash_final($ctx);
+echo hash_final($ctx);
?>
--EXPECT--
bool(true)
+5c6ffbdd40d9556b73a21e63c3e0e904
+--CLEAN--
+<?php
+unlink(__DIR__ . DIRECTORY_SEPARATOR . 'hash_update_stream.txt');
+?>