summaryrefslogtreecommitdiff
path: root/ext/hash
diff options
context:
space:
mode:
authorAnatol Belski <ab@php.net>2017-11-17 21:35:22 +0100
committerAnatol Belski <ab@php.net>2017-11-17 22:38:44 +0100
commit80d6eb6806a6317c99a2608e28f42869c834d0e7 (patch)
tree2b50e7efc4de4ad81d777b4d5bcc54ef4ff196e7 /ext/hash
parent3ce1a977d42d3e74912be381c326faf0b6126206 (diff)
downloadphp-git-80d6eb6806a6317c99a2608e28f42869c834d0e7.tar.gz
Fix unsigned comparisons and remove dead code
Fix unsigned comparison Cleanup never executed block Fix unsigned comparison Fix unsigned comparison, diff can't be < 0 Fix unsigned comparison Fix unsigned comparison Remove dead code
Diffstat (limited to 'ext/hash')
-rw-r--r--ext/hash/hash.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ext/hash/hash.c b/ext/hash/hash.c
index 9819a6e7ed..d8e95ea1a0 100644
--- a/ext/hash/hash.c
+++ b/ext/hash/hash.c
@@ -357,7 +357,7 @@ static void php_hashcontext_ctor(INTERNAL_FUNCTION_PARAMETERS, zval *objval) {
zval_dtor(return_value);
RETURN_FALSE;
}
- if (!key || (ZSTR_LEN(key) <= 0)) {
+ if (!key || (ZSTR_LEN(key) == 0)) {
/* Note: a zero length key is no key at all */
php_error_docref(NULL, E_WARNING, "HMAC requested without a key");
zval_dtor(return_value);