summaryrefslogtreecommitdiff
path: root/ext/mbstring/php_mbregex.c
diff options
context:
space:
mode:
authorNikita Popov <nikita.ppv@gmail.com>2019-01-08 10:21:01 +0100
committerNikita Popov <nikita.ppv@gmail.com>2019-01-08 10:21:01 +0100
commit76c687feaf86d305f8ba510a7319ccc1b66a8901 (patch)
treea8a703009746e5489c75a74be8203fdfdf9d0fbb /ext/mbstring/php_mbregex.c
parent7f8cab2535afc9057b1d04d236450d5f048939c4 (diff)
downloadphp-git-76c687feaf86d305f8ba510a7319ccc1b66a8901.tar.gz
Fixed bug #77428
mb_ereg_replace historically has not supported escaping backslashes with backslashes. Go back to that behavior for BC reasons.
Diffstat (limited to 'ext/mbstring/php_mbregex.c')
-rw-r--r--ext/mbstring/php_mbregex.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/ext/mbstring/php_mbregex.c b/ext/mbstring/php_mbregex.c
index 85219b00e4..cc96e04f39 100644
--- a/ext/mbstring/php_mbregex.c
+++ b/ext/mbstring/php_mbregex.c
@@ -791,7 +791,9 @@ static inline void mb_regex_substitute(
no = onig_name_to_backref_number(regexp, (OnigUChar *)name, (OnigUChar *)name_end, regs);
break;
default:
- p += clen;
+ /* We're not treating \ as an escape character and will interpret something like
+ * \\1 as \ followed by \1, rather than \\ followed by 1. This is because this
+ * function has not supported escaping of backslashes historically. */
smart_str_appendl(pbuf, sp, p - sp);
continue;
}