diff options
| author | Andrey Hristov <andrey@php.net> | 2009-05-28 17:49:29 +0000 |
|---|---|---|
| committer | Andrey Hristov <andrey@php.net> | 2009-05-28 17:49:29 +0000 |
| commit | 804f6138a69a6f465c3b223957f75272089d4f05 (patch) | |
| tree | d6111c4b6b2239e776074db1b8556dfe4d278f96 /ext/mysqlnd | |
| parent | 76d091d5f55d69cd275feda5d8ac70cd42abbd3a (diff) | |
| download | php-git-804f6138a69a6f465c3b223957f75272089d4f05.tar.gz | |
MFH:Fix a valgrind warning as well as more trace log information
Diffstat (limited to 'ext/mysqlnd')
| -rw-r--r-- | ext/mysqlnd/mysqlnd_ps.c | 1 | ||||
| -rw-r--r-- | ext/mysqlnd/mysqlnd_result.c | 7 | ||||
| -rw-r--r-- | ext/mysqlnd/mysqlnd_result_meta.c | 7 |
3 files changed, 14 insertions, 1 deletions
diff --git a/ext/mysqlnd/mysqlnd_ps.c b/ext/mysqlnd/mysqlnd_ps.c index 3427157617..f0dca777eb 100644 --- a/ext/mysqlnd/mysqlnd_ps.c +++ b/ext/mysqlnd/mysqlnd_ps.c @@ -1373,6 +1373,7 @@ MYSQLND_METHOD(mysqlnd_stmt, bind_parameters)(MYSQLND_STMT * const stmt, /* Prevent from freeing */ /* Don't update is_ref, or we will leak during conversion */ Z_ADDREF_P(stmt->param_bind[i].zv); + stmt->param_bind[i].flags = 0; if (stmt->param_bind[i].type == MYSQL_TYPE_LONG_BLOB) { stmt->param_bind[i].flags &= ~MYSQLND_PARAM_BIND_BLOB_USED; } diff --git a/ext/mysqlnd/mysqlnd_result.c b/ext/mysqlnd/mysqlnd_result.c index e161f28854..bafc0ce064 100644 --- a/ext/mysqlnd/mysqlnd_result.c +++ b/ext/mysqlnd/mysqlnd_result.c @@ -100,8 +100,10 @@ void mysqlnd_res_initialize_result_set_rest(MYSQLND_RES * const result TSRMLS_DC zval **data_begin = result->stored_data->data; unsigned int field_count = result->meta->field_count; unsigned int row_count = result->stored_data->row_count; + DBG_ENTER("mysqlnd_res_initialize_result_set_rest"); + if (!data_cursor || row_count == result->stored_data->initialized_rows) { - return; + DBG_VOID_RETURN; } while ((data_cursor - data_begin) < (row_count * field_count)) { if (NULL == data_cursor[0]) { @@ -128,6 +130,7 @@ void mysqlnd_res_initialize_result_set_rest(MYSQLND_RES * const result TSRMLS_DC } data_cursor += field_count; } + DBG_VOID_RETURN; } /* }}} */ @@ -1752,6 +1755,7 @@ MYSQLND_METHOD(mysqlnd_res, fetch_field)(MYSQLND_RES * const result TSRMLS_DC) not during mysqli_fetch_field() time. */ if (result->stored_data && (result->stored_data->initialized_rows < result->stored_data->row_count)) { + DBG_INF_FMT("We have decode the whole result set to be able to satisfy this meta request"); /* we have to initialize the rest to get the updated max length */ mysqlnd_res_initialize_result_set_rest(result TSRMLS_CC); } @@ -1780,6 +1784,7 @@ MYSQLND_METHOD(mysqlnd_res, fetch_field_direct)(MYSQLND_RES * const result, not during mysqli_fetch_field_direct() time. */ if (result->stored_data && (result->stored_data->initialized_rows < result->stored_data->row_count)) { + DBG_INF_FMT("We have decode the whole result set to be able to satisfy this meta request"); /* we have to initialized the rest to get the updated max length */ mysqlnd_res_initialize_result_set_rest(result TSRMLS_CC); } diff --git a/ext/mysqlnd/mysqlnd_result_meta.c b/ext/mysqlnd/mysqlnd_result_meta.c index 0644b0f09c..c970749ab6 100644 --- a/ext/mysqlnd/mysqlnd_result_meta.c +++ b/ext/mysqlnd/mysqlnd_result_meta.c @@ -372,8 +372,12 @@ MYSQLND_METHOD(mysqlnd_res_meta, fetch_field)(MYSQLND_RES_METADATA * const meta { DBG_ENTER("mysqlnd_res_meta::fetch_field"); if (meta->current_field >= meta->field_count) { + DBG_INF("no more fields"); DBG_RETURN(NULL); } + DBG_INF_FMT("name=%s max_length=%u", + meta->fields[meta->current_field].name? meta->fields[meta->current_field].name:"", + meta->fields[meta->current_field].max_length); DBG_RETURN(&meta->fields[meta->current_field++]); } /* }}} */ @@ -386,6 +390,9 @@ MYSQLND_METHOD(mysqlnd_res_meta, fetch_field_direct)(const MYSQLND_RES_METADATA { DBG_ENTER("mysqlnd_res_meta::fetch_field_direct"); DBG_INF_FMT("fieldnr=%d", fieldnr); + DBG_INF_FMT("name=%s max_length=%u", + meta->fields[meta->current_field].name? meta->fields[meta->current_field].name:"", + meta->fields[meta->current_field].max_length); DBG_RETURN(&meta->fields[fieldnr]); } /* }}} */ |
