diff options
author | Christoph M. Becker <cmbecker69@gmx.de> | 2018-12-01 00:13:58 +0100 |
---|---|---|
committer | Christoph M. Becker <cmbecker69@gmx.de> | 2018-12-01 00:13:58 +0100 |
commit | 12410df5fb38cd092d29f67006e4ba22463068da (patch) | |
tree | d9e813ea301c70194ccba2901195505801589732 /ext/pdo_sqlite/sqlite_driver.c | |
parent | ea1ea33bd5d967e9c04046c1af869e4e8b53116e (diff) | |
download | php-git-12410df5fb38cd092d29f67006e4ba22463068da.tar.gz |
Fix illogical strncpy size
While both source and destination buffers have the same size (6 bytes),
and this is unlikely to change in the future, we nonetheless fix the
illogical `strncpy` size.
Based on a pull request provided by Cristian RodrÃguez.
Diffstat (limited to 'ext/pdo_sqlite/sqlite_driver.c')
-rw-r--r-- | ext/pdo_sqlite/sqlite_driver.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/ext/pdo_sqlite/sqlite_driver.c b/ext/pdo_sqlite/sqlite_driver.c index 07285d8acc..57b8444b77 100644 --- a/ext/pdo_sqlite/sqlite_driver.c +++ b/ext/pdo_sqlite/sqlite_driver.c @@ -45,33 +45,33 @@ int _pdo_sqlite_error(pdo_dbh_t *dbh, pdo_stmt_t *stmt, const char *file, int li } einfo->errmsg = pestrdup((char*)sqlite3_errmsg(H->db), dbh->is_persistent); } else { /* no error */ - strncpy(*pdo_err, PDO_ERR_NONE, sizeof(PDO_ERR_NONE)); + strncpy(*pdo_err, PDO_ERR_NONE, sizeof(*pdo_err)); return 0; } switch (einfo->errcode) { case SQLITE_NOTFOUND: - strncpy(*pdo_err, "42S02", sizeof("42S02")); + strncpy(*pdo_err, "42S02", sizeof(*pdo_err)); break; case SQLITE_INTERRUPT: - strncpy(*pdo_err, "01002", sizeof("01002")); + strncpy(*pdo_err, "01002", sizeof(*pdo_err)); break; case SQLITE_NOLFS: - strncpy(*pdo_err, "HYC00", sizeof("HYC00")); + strncpy(*pdo_err, "HYC00", sizeof(*pdo_err)); break; case SQLITE_TOOBIG: - strncpy(*pdo_err, "22001", sizeof("22001")); + strncpy(*pdo_err, "22001", sizeof(*pdo_err)); break; case SQLITE_CONSTRAINT: - strncpy(*pdo_err, "23000", sizeof("23000")); + strncpy(*pdo_err, "23000", sizeof(*pdo_err)); break; case SQLITE_ERROR: default: - strncpy(*pdo_err, "HY000", sizeof("HY000")); + strncpy(*pdo_err, "HY000", sizeof(*pdo_err)); break; } |