implement phar refcounting

move setStub to commitWrite() and add beginWrite()

# many oo-based tests still fail, they need to be tweaked and fixed

1 files changed, 4 insertions, 3 deletions

diff --git a/ext/phar/TODO b/ext/phar/TODO
index d8c5f8c53e..bd0b2f7ba4 100644
--- a/ext/phar/TODO
+++ b/ext/phar/TODO
@@ -8,13 +8,14 @@ Version 1.0.0
  X implement writing out of metadata to new manifest [Marcus]
  X if SPL is disabled, enable only static methods of class Phar and disable 
    class PharFileInfo completely [Marcus]
- * implement in-phar locking, so that a file that is opened for reading can't 
-   have a handle opened for writing
+ X implement in-phar locking, so that a file that is opened for reading can't 
+   have a handle opened for writing [Greg]
  X docs on file format/manifest description
  * docs on uses
  X stream context for specifying compression of a file [Marcus]
  * stream context for specifying meta-data
- X Phar->setStub() for specifying a new stub to the phar [Greg]
+ X Phar->begin()/Phar->commitWrite() for specifying a new stub to the phar,
+   and deferring flush until all modifications are complete [Greg]
  X Phar->getStub() for retrieving the stub of the phar [Marcus]
  X add setUncompressed(), setCompressedGZ() and setCompressedBZ2() to 
    PharFileInfo class [Greg]