summaryrefslogtreecommitdiff
path: root/ext/reflection
diff options
context:
space:
mode:
authorNikita Popov <nikic@php.net>2016-04-29 22:00:54 +0200
committerNikita Popov <nikic@php.net>2016-04-29 22:02:31 +0200
commit5595dd5ffa3453f22c0508052417d3b2853f5015 (patch)
treefec0ef2a6f51102661fc7d2888a93a7879ce89ab /ext/reflection
parent2c5704bdc228bd13a1152aedeeadb831dd782fd3 (diff)
downloadphp-git-5595dd5ffa3453f22c0508052417d3b2853f5015.tar.gz
Revert code to use DUP instead of COPY
In a1c405e0c50c627cdd9a7695b4c7d644238b6b9b next to the actual fix I have also switched some (effective) ZVAL_DUPs to ZVAL_COPYs. I'm reverting this part as those were probably there for a reason (presumably issues with non-atomic refcounting on ZTS).
Diffstat (limited to 'ext/reflection')
-rw-r--r--ext/reflection/php_reflection.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
index d618627178..5b8569e9f2 100644
--- a/ext/reflection/php_reflection.c
+++ b/ext/reflection/php_reflection.c
@@ -2884,7 +2884,7 @@ ZEND_METHOD(reflection_parameter, getDefaultValue)
return;
}
- ZVAL_COPY(return_value, RT_CONSTANT(&param->fptr->op_array, precv->op2));
+ ZVAL_DUP(return_value, RT_CONSTANT(&param->fptr->op_array, precv->op2));
if (Z_CONSTANT_P(return_value)) {
zval_update_constant_ex(return_value, param->fptr->common.scope);
}