Rename standard array function parameters to $array

This is targeting 8.0.

`$arg` seems like a poor choice of a name,
especially if the function were to have arguments added.

In many cases, the php.net documentation already has $array for these functions.
E.g. https://www.php.net/manual/en/function.array-intersect.php

I'd assume that since named arguments was added to 8.0 near the feature freeze,
PHP's maintainers had planned to make the names consistent
and gradually use the same name for  docs and implementation.

1 files changed, 6 insertions, 6 deletions

diff --git a/ext/reflection/tests/ReflectionParameter_canBePassedByValue.phpt b/ext/reflection/tests/ReflectionParameter_canBePassedByValue.phpt
index da08cc6288..c5a7b72714 100644
--- a/ext/reflection/tests/ReflectionParameter_canBePassedByValue.phpt
+++ b/ext/reflection/tests/ReflectionParameter_canBePassedByValue.phpt
@@ -27,7 +27,7 @@ aux('sort');
 
 echo "=> user function:\n\n";
 
-function ufunc(&$arg1, $arg2) {}
+function ufunc(&$array1, $array2) {}
 
 aux('ufunc');
 
@@ -37,7 +37,7 @@ echo "Done.\n";
 --EXPECT--
 => array_multisort:
 
-Name: arr1
+Name: array1
 Is passed by reference: yes
 Can be passed by value: yes
 
@@ -49,13 +49,13 @@ Name: sort_flags
 Is passed by reference: yes
 Can be passed by value: yes
 
-Name: arr2
+Name: arrays
 Is passed by reference: yes
 Can be passed by value: yes
 
 => sort:
 
-Name: arg
+Name: array
 Is passed by reference: yes
 Can be passed by value: no
 
@@ -65,11 +65,11 @@ Can be passed by value: yes
 
 => user function:
 
-Name: arg1
+Name: array1
 Is passed by reference: yes
 Can be passed by value: no
 
-Name: arg2
+Name: array2
 Is passed by reference: no
 Can be passed by value: yes