diff options
| author | Daniel Stenberg <daniel@haxx.se> | 2019-03-07 00:06:00 +0100 |
|---|---|---|
| committer | Nikita Popov <nikita.ppv@gmail.com> | 2019-03-11 09:56:25 +0100 |
| commit | d9d253fa6bf8e89a48a3e4ce6a669c705564e254 (patch) | |
| tree | 408170c71b5be0420897c5b387cb4d351eaeeff6 /ext/session/mod_user.c | |
| parent | 4a12fb4abad611f2a4705f83842b3e833e0e100d (diff) | |
| download | php-git-d9d253fa6bf8e89a48a3e4ce6a669c705564e254.tar.gz | |
curl_exec: remove bad check for CURLE_PARTIAL_FILE
This check introduced in 2004 is wrong and removed. A HEAD request with
curl does *not* cause this error code - only if you make a regular GET
request but tell curl to send a HEAD using CURLOPT_CUSTOMREQUEST and
then you've asked for it.
You do a proper HEAD request with curl by setting the CURLOPT_NOBODY
option to 1L.
This was the case in 2004. This is still the case in 2019. This is also
documented in libcurl documentation.
This check hides the possibly serious error when this error code is
genuinely and correctly returned by curl because the transfer was
truncated and ended up partial.
As can be seen, I objected to this change already in the original bug:
https://bugs.php.net/bug.php?id=27341
Diffstat (limited to 'ext/session/mod_user.c')
0 files changed, 0 insertions, 0 deletions