diff options
| author | Leigh <leight@gmail.com> | 2012-06-26 14:57:10 +0100 |
|---|---|---|
| committer | Leigh <leight@gmail.com> | 2012-06-26 14:57:10 +0100 |
| commit | 6809c388b5d8bb03515f7b4ba391724f9a8df8e0 (patch) | |
| tree | 10347b5e49b2c0341263a052fce6a9f4a6664df0 /ext/session/mod_user_class.c | |
| parent | 59cf3a2404dc5d678ee16249764b7effd6ecd485 (diff) | |
| download | php-git-6809c388b5d8bb03515f7b4ba391724f9a8df8e0.tar.gz | |
Tests, fixes and optimisations
* Amended existing tests to cater for new functionality.
* Implemented fixes and optimisations recommended by NikiC
* Added create_sid to the registered interface. This was breaking
tests. It also now breaks BC for people implementing the interface
directly instead of extending the class.
Diffstat (limited to 'ext/session/mod_user_class.c')
| -rw-r--r-- | ext/session/mod_user_class.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/ext/session/mod_user_class.c b/ext/session/mod_user_class.c index a996902dac..4387bddadf 100644 --- a/ext/session/mod_user_class.c +++ b/ext/session/mod_user_class.c @@ -149,12 +149,12 @@ PHP_METHOD(SessionHandler, create_sid) { char *id; - zend_parse_parameters_none(); + if (zend_parse_parameters_none() == FAILURE) { + return; + } id = PS(default_mod)->s_create_sid(&PS(mod_data), NULL TSRMLS_CC); - RETVAL_STRING(id, 1); - efree(id); - return; + RETURN_STRING(id, 0); } /* }}} */ |