summaryrefslogtreecommitdiff
path: root/ext/session
diff options
context:
space:
mode:
authorYasuo Ohgaki <yohgaki@php.net>2014-01-15 11:07:10 +0900
committerYasuo Ohgaki <yohgaki@php.net>2014-01-15 11:07:10 +0900
commit167eaedcbdb494c87c4f83d2897a9fdb614e7062 (patch)
tree49b9df0913d56d2a88a4569f13affd98b79713d4 /ext/session
parenta5ee337156027e06966586984eff15e19efbf3cd (diff)
parentf52c251f60c8c6d1bd01f3d87d69ed45f7a1bfa4 (diff)
downloadphp-git-167eaedcbdb494c87c4f83d2897a9fdb614e7062.tar.gz
Merge branch 'PHP-5.5' into PHP-5.6
* PHP-5.5: Fixed session module is sending multiple set-cookie headers when session.use_strict_mode=1
Diffstat (limited to 'ext/session')
-rw-r--r--ext/session/mod_files.c1
-rw-r--r--ext/session/mod_mm.c1
-rw-r--r--ext/session/session.c14
3 files changed, 13 insertions, 3 deletions
diff --git a/ext/session/mod_files.c b/ext/session/mod_files.c
index c365760eb7..4d5a18b36b 100644
--- a/ext/session/mod_files.c
+++ b/ext/session/mod_files.c
@@ -342,6 +342,7 @@ PS_READ_FUNC(files)
PS(send_cookie) = 1;
}
php_session_reset_id(TSRMLS_C);
+ PS(session_status) = php_session_active;
}
ps_files_open(data, PS(id) TSRMLS_CC);
diff --git a/ext/session/mod_mm.c b/ext/session/mod_mm.c
index 41df247e74..319f1d3c79 100644
--- a/ext/session/mod_mm.c
+++ b/ext/session/mod_mm.c
@@ -371,6 +371,7 @@ PS_READ_FUNC(mm)
PS(send_cookie) = 1;
}
php_session_reset_id(TSRMLS_C);
+ PS(session_status) = php_session_active;
}
sd = ps_sd_lookup(data, PS(id), 0);
diff --git a/ext/session/session.c b/ext/session/session.c
index 7a5254f8a9..cffdabb7b7 100644
--- a/ext/session/session.c
+++ b/ext/session/session.c
@@ -492,18 +492,26 @@ static void php_session_initialize(TSRMLS_D) /* {{{ */
}
}
- php_session_reset_id(TSRMLS_C);
- PS(session_status) = php_session_active;
+ /* Set session ID for compatibility for older/3rd party save handlers */
+ if (!PS(use_strict_mode)) {
+ php_session_reset_id(TSRMLS_C);
+ PS(session_status) = php_session_active;
+ }
/* Read data */
php_session_track_init(TSRMLS_C);
if (PS(mod)->s_read(&PS(mod_data), PS(id), &val, &vallen TSRMLS_CC) == FAILURE) {
/* Some broken save handler implementation returns FAILURE for non-existent session ID */
- /* It's better to rase error for this, but disabled error for better compatibility */
+ /* It's better to raise error for this, but disabled error for better compatibility */
/*
php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Failed to read session data: %s (path: %s)", PS(mod)->s_name, PS(save_path));
*/
}
+ /* Set session ID if session read didn't activated session */
+ if (PS(use_strict_mode) && PS(session_status) != php_session_active) {
+ php_session_reset_id(TSRMLS_C);
+ PS(session_status) = php_session_active;
+ }
if (val) {
PHP_MD5_CTX context;