summaryrefslogtreecommitdiff
path: root/ext/session
diff options
context:
space:
mode:
authorJoe Watkins <krakjoe@php.net>2017-01-19 10:49:09 +0000
committerJoe Watkins <krakjoe@php.net>2017-01-19 10:49:09 +0000
commit71a42477ca07f6c6ec0621b06c1cea318a05b97a (patch)
treec408ccbf5823726f2187c9c34dbbe5f50bffab53 /ext/session
parent0311dc86978ac3d20a7a8d7e502e2e0b6fd6dc46 (diff)
parent631861e1fa93b19788def94cf456d2993551c17f (diff)
downloadphp-git-71a42477ca07f6c6ec0621b06c1cea318a05b97a.tar.gz
Merge branch 'PHP-7.1'
* PHP-7.1: Update comment, incorrect since 224aaf94
Diffstat (limited to 'ext/session')
-rw-r--r--ext/session/session.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/ext/session/session.c b/ext/session/session.c
index 6323020f68..02f8d8d881 100644
--- a/ext/session/session.c
+++ b/ext/session/session.c
@@ -435,8 +435,7 @@ static int php_session_initialize(void) /* {{{ */
php_session_track_init();
if (PS(mod)->s_read(&PS(mod_data), PS(id), &val, PS(gc_maxlifetime)) == FAILURE) {
php_session_abort();
- /* Some broken save handler implementation returns FAILURE for non-existent session ID */
- /* It's better to raise error for this, but disabled error for better compatibility */
+ /* FYI: Some broken save handlers return FAILURE for non-existent session ID, this is incorrect */
php_error_docref(NULL, E_WARNING, "Failed to read session data: %s (path: %s)", PS(mod)->s_name, PS(save_path));
return FAILURE;
}