We don't consistently check for args passed to functions that don't

take any args.  In some cases we probably want to skip the check for
performance reasons, but in other cases where performance is unlikely
to be a factor, not throwing a warning on the wrong number of args passed
to a function is at best inconsistent, and at worst it could hide a bug.
So, add a few such checks.  There are still lots of cases out there.

1 files changed, 9 insertions, 6 deletions

diff --git a/ext/snmp/snmp.c b/ext/snmp/snmp.c
index 6b635b196a..56c87e4dc4 100644
--- a/ext/snmp/snmp.c
+++ b/ext/snmp/snmp.c
@@ -402,6 +402,9 @@ PHP_FUNCTION(snmprealwalk)
    Return the current status of quick_print */
 PHP_FUNCTION(snmp_get_quick_print)
 {
+	if (zend_parse_parameters(ZEND_NUM_ARGS(), "") == FAILURE)
+		return;
+
 	RETURN_LONG(snmp_get_quick_print() ? 1 : 0);
 }
 /* }}} */
@@ -410,12 +413,12 @@ PHP_FUNCTION(snmp_get_quick_print)
    Return all objects including their respective object id withing the specified one */
 PHP_FUNCTION(snmp_set_quick_print)
 {
-	zval **a1;
-	if (ZEND_NUM_ARGS() != 1 || zend_get_parameters_ex(1, &a1) == FAILURE) {
-		WRONG_PARAM_COUNT;
-	}
-	convert_to_long_ex(a1);
-	snmp_set_quick_print((int)(*a1)->value.lval);
+	int argc = ZEND_NUM_ARGS();
+	long a1;
+
+	if (zend_parse_parameters(argc, "l", &a1) == FAILURE)
+		return;
+	snmp_set_quick_print((int)a1);
 }
 /* }}} */