diff options
| author | Christoph M. Becker <cmbecker69@gmx.de> | 2016-11-16 11:49:04 +0100 |
|---|---|---|
| committer | Christoph M. Becker <cmbecker69@gmx.de> | 2016-11-16 11:49:04 +0100 |
| commit | eb570294a289b45d0dd38efc71065d6b0d314c4b (patch) | |
| tree | cfa73c5288dcfeff8a5b16070e11eabc127e5082 /ext/sqlite3/sqlite3.c | |
| parent | ecba563f2fa1e027ea91b9ee0d50611273852995 (diff) | |
| download | php-git-eb570294a289b45d0dd38efc71065d6b0d314c4b.tar.gz | |
Fix #73530: Unsetting result set may reset other result set
Calling sqlite3_reset() when a result set object is freed can cause
undesired and maybe even hard to track interference with other result
sets. Furthermore, there is no need to call sqlite3_reset(), because
that is implicitly called on SQLite3Stmt::execute(), and users are
encouraged to explicitly call either SQLite3Result::finalize() or
SQLite3Stmt::reset() anyway.
Diffstat (limited to 'ext/sqlite3/sqlite3.c')
| -rw-r--r-- | ext/sqlite3/sqlite3.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/ext/sqlite3/sqlite3.c b/ext/sqlite3/sqlite3.c index 80d6b897f1..b443657e3c 100644 --- a/ext/sqlite3/sqlite3.c +++ b/ext/sqlite3/sqlite3.c @@ -2184,10 +2184,6 @@ static void php_sqlite3_result_object_free_storage(void *object TSRMLS_DC) /* {{ } if (intern->stmt_obj_zval) { - if (intern->stmt_obj->initialised) { - sqlite3_reset(intern->stmt_obj->stmt); - } - if (intern->is_prepared_statement == 0) { zval_dtor(intern->stmt_obj_zval); FREE_ZVAL(intern->stmt_obj_zval); |