diff options
| author | Dmitry Stogov <dmitry@zend.com> | 2016-11-18 16:17:52 +0300 |
|---|---|---|
| committer | Dmitry Stogov <dmitry@zend.com> | 2016-11-18 16:17:52 +0300 |
| commit | 97b65cc9c2b2c50d974622458719756eb8e62003 (patch) | |
| tree | 2816016318dd8682aea9d9d76c23e29efc77eb64 /ext/standard/basic_functions.c | |
| parent | 0c78fe4bb55a9d39afc79cbcbadb9a273f2ec2ef (diff) | |
| download | php-git-97b65cc9c2b2c50d974622458719756eb8e62003.tar.gz | |
Fixed memory leaks in parse_ini_file()
Diffstat (limited to 'ext/standard/basic_functions.c')
| -rw-r--r-- | ext/standard/basic_functions.c | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/ext/standard/basic_functions.c b/ext/standard/basic_functions.c index 09124fa025..caf46aa675 100644 --- a/ext/standard/basic_functions.c +++ b/ext/standard/basic_functions.c @@ -5796,8 +5796,6 @@ PHP_FUNCTION(move_uploaded_file) */ static void php_simple_ini_parser_cb(zval *arg1, zval *arg2, zval *arg3, int callback_type, zval *arr) { - zval element; - switch (callback_type) { case ZEND_INI_PARSER_ENTRY: @@ -5805,8 +5803,8 @@ static void php_simple_ini_parser_cb(zval *arg1, zval *arg2, zval *arg3, int cal /* bare string - nothing to do */ break; } - ZVAL_DUP(&element, arg2); - zend_symtable_update(Z_ARRVAL_P(arr), Z_STR_P(arg1), &element); + Z_TRY_ADDREF_P(arg2); + zend_symtable_update(Z_ARRVAL_P(arr), Z_STR_P(arg1), arg2); break; case ZEND_INI_PARSER_POP_ENTRY: @@ -5836,12 +5834,11 @@ static void php_simple_ini_parser_cb(zval *arg1, zval *arg2, zval *arg3, int cal array_init(find_hash); } - ZVAL_DUP(&element, arg2); if (!arg3 || (Z_TYPE_P(arg3) == IS_STRING && Z_STRLEN_P(arg3) == 0)) { - add_next_index_zval(find_hash, &element); + Z_TRY_ADDREF_P(arg2); + add_next_index_zval(find_hash, arg2); } else { - array_set_zval_key(Z_ARRVAL_P(find_hash), arg3, &element); - zval_ptr_dtor(&element); + array_set_zval_key(Z_ARRVAL_P(find_hash), arg3, arg2); } } break; |