diff options
| author | Ilia Alshanetsky <iliaa@php.net> | 2003-02-26 22:11:12 +0000 |
|---|---|---|
| committer | Ilia Alshanetsky <iliaa@php.net> | 2003-02-26 22:11:12 +0000 |
| commit | 695ae92c9765018dbb3738f6733065ad27c3d4c2 (patch) | |
| tree | bec1e7954b1d52cdee7f6d356d342d8a21146348 /ext/standard/exec.h | |
| parent | d737741329bf41267cfc92adb0618a0fd67a8c3e (diff) | |
| download | php-git-695ae92c9765018dbb3738f6733065ad27c3d4c2.tar.gz | |
1) Make the output of system() binary safe
2) Solved a memory leak when the return_value variable passed by reference is
not an integer in system()/exec()/passthru().
3) Solved a bug in exec(), which would make it append to the 2nd parameter
(passed by reference) if the parameter is an array instead of overwriting it.
4) Changed the code to use the streams code, resulting in a smaller code base.
5) Various cleanups resulting in reduction of overall code base inside the file
by ~ 1/3.
6) Speed improvements of ~2.5 times compared to previous performance (based on
attached PHP script).
Diffstat (limited to 'ext/standard/exec.h')
| -rw-r--r-- | ext/standard/exec.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/ext/standard/exec.h b/ext/standard/exec.h index a0d4ab46ae..6d5fb66f70 100644 --- a/ext/standard/exec.h +++ b/ext/standard/exec.h @@ -36,8 +36,6 @@ PHP_MINIT_FUNCTION(proc_open); char *php_escape_shell_cmd(char *); char *php_escape_shell_arg(char *); -int php_Exec(int type, char *cmd, pval *array, pval *return_value TSRMLS_DC); - -#define PHP_EMPTY_EXEC_PARAM { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Cannot execute a blank command"); RETURN_FALSE; } +int php_exec(int type, char *cmd, pval *array, pval *return_value TSRMLS_DC); #endif /* EXEC_H */ |