diff options
| author | Jakub Zelenka <bukka@php.net> | 2016-06-26 14:03:01 +0100 |
|---|---|---|
| committer | Jakub Zelenka <bukka@php.net> | 2016-06-26 14:03:01 +0100 |
| commit | 3f13507dd281adf0518c9162dce5391e9250e93b (patch) | |
| tree | 70f4addc37de995e1a58e5baec180e0ef266a937 /ext/standard/var.c | |
| parent | 158b537c99ca5fc7846e7d16d532644be95894a7 (diff) | |
| download | php-git-3f13507dd281adf0518c9162dce5391e9250e93b.tar.gz | |
Use one place to define max length of double
Introduce new constant PHP_DOUBLE_MAX_LENGTH for that purpose
Diffstat (limited to 'ext/standard/var.c')
| -rw-r--r-- | ext/standard/var.c | 15 |
1 files changed, 2 insertions, 13 deletions
diff --git a/ext/standard/var.c b/ext/standard/var.c index e0938fe6e9..809161afec 100644 --- a/ext/standard/var.c +++ b/ext/standard/var.c @@ -35,17 +35,6 @@ #define COMMON (is_ref ? "&" : "") -/* Copied from main/spprintf.c and use the same buffer size - * - * NUM_BUF_SIZE is the size of the buffer used for arithmetic conversions - * - * XXX: this is a magic number; do not decrease it - * Emax = 1023 - * NDIG = 320 - * NUM_BUF_SIZE >= strlen("-") + Emax + strlrn(".") + NDIG + strlen("E+1023") + 1; - */ -#define NUM_BUF_SIZE 2048 - static void php_array_element_dump(zval *zv, zend_ulong index, zend_string *key, int level) /* {{{ */ { if (key == NULL) { /* numeric key */ @@ -447,7 +436,7 @@ static void php_object_element_export(zval *zv, zend_ulong index, zend_string *k PHPAPI void php_var_export_ex(zval *struc, int level, smart_str *buf) /* {{{ */ { HashTable *myht; - char tmp_str[NUM_BUF_SIZE]; + char tmp_str[PHP_DOUBLE_MAX_LENGTH]; zend_string *ztmp, *ztmp2; zend_ulong index; zend_string *key; @@ -853,7 +842,7 @@ again: return; case IS_DOUBLE: { - char tmp_str[NUM_BUF_SIZE]; + char tmp_str[PHP_DOUBLE_MAX_LENGTH]; smart_str_appendl(buf, "d:", 2); php_gcvt(Z_DVAL_P(struc), (int)PG(serialize_precision), '.', 'E', tmp_str); smart_str_appends(buf, tmp_str); |