summaryrefslogtreecommitdiff
path: root/sapi/cli/php_cli_server.c
diff options
context:
space:
mode:
authorXinchen Hui <laruence@gmail.com>2017-10-15 10:28:28 +0800
committerXinchen Hui <laruence@gmail.com>2017-10-15 10:28:28 +0800
commit816758eda2bcdd69ba505fb6bbb79124a7bf2254 (patch)
tree87036bd591f5ddbcfe02aeaf669fcf22989c2983 /sapi/cli/php_cli_server.c
parent397f5cb687f4f31cb0dec85ba5a87237394ca12d (diff)
downloadphp-git-816758eda2bcdd69ba505fb6bbb79124a7bf2254.tar.gz
Fixed bug #75287 (Builtin webserver crash after chdir in a shutdown function)
Diffstat (limited to 'sapi/cli/php_cli_server.c')
-rw-r--r--sapi/cli/php_cli_server.c30
1 files changed, 14 insertions, 16 deletions
diff --git a/sapi/cli/php_cli_server.c b/sapi/cli/php_cli_server.c
index 39ded2f5b3..48480bb1e2 100644
--- a/sapi/cli/php_cli_server.c
+++ b/sapi/cli/php_cli_server.c
@@ -2106,12 +2106,6 @@ static int php_cli_server_dispatch_router(php_cli_server *server, php_cli_server
{
int decline = 0;
zend_file_handle zfd;
- char *old_cwd;
-
- ALLOCA_FLAG(use_heap)
- old_cwd = do_alloca(MAXPATHLEN, use_heap);
- old_cwd[0] = '\0';
- php_ignore_value(VCWD_GETCWD(old_cwd, MAXPATHLEN - 1));
zfd.type = ZEND_HANDLE_FILENAME;
zfd.filename = server->router;
@@ -2133,12 +2127,6 @@ static int php_cli_server_dispatch_router(php_cli_server *server, php_cli_server
}
} zend_end_try();
- if (old_cwd[0] != '\0') {
- php_ignore_value(VCWD_CHDIR(old_cwd));
- }
-
- free_alloca(old_cwd, use_heap);
-
return decline;
}
/* }}} */
@@ -2330,10 +2318,20 @@ static int php_cli_server_ctor(php_cli_server *server, const char *addr, const c
if (router) {
size_t router_len = strlen(router);
- _router = pestrndup(router, router_len, 1);
- if (!_router) {
- retval = FAILURE;
- goto out;
+ if (!IS_ABSOLUTE_PATH(router, router_len)) {
+ _router = pemalloc(server->document_root_len + router_len + 2, 1);
+ if (!_router) {
+ retval = FAILURE;
+ goto out;
+ }
+ snprintf(_router,
+ server->document_root_len + router_len + 2, "%s%c%s", server->document_root, DEFAULT_SLASH, router);
+ } else {
+ _router = pestrndup(router, router_len, 1);
+ if (!_router) {
+ retval = FAILURE;
+ goto out;
+ }
}
server->router = _router;
server->router_len = router_len;