| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | | |
| | |
| | |
| | | |
We use the proper type for size calculations, which is `size_t`.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
We must not cast `size_t` to `int` (unless the `size_t` value is
guaranteed to be less than or equal to `INT_MAX`). In this case we can
declare `array_len` as `size_t` in the first place.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
We must not attempt to access arbitrary union members when retrieving
debug info, because that may not be valid. Therefore we do no longer
dereference pointer types inside of unions, but report their address as
string in `%p` format instead.
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix default sendmail path when not found during build
|
| | | |
| | |
| | |
| | | |
Closes GH-5548.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a funny one. I discovered that lstat_stat_variation10.phpt was failing every
now and again when the PHP test suite was run on my dev PC. The output from the failing
test showed that the atime (access time) of the directory created in the test was changing
between these lines:
$old_stat = stat($dirname);
clearstatcache();
sleep(1);
var_dump( is_dir($dirname) );
$new_stat = stat($dirname);
Could is_dir() be accessing the directory and changing the atime? strace showed that is_dir
was only issuing a single stat() syscall. Could stat() change the atime? No, no, that would
just be perverse. Nobody would be stupid enough to implement the kernel in that way.
Checked the kernel source, found that the function called when atime needs to be updated
appears to be touch_atime(). Broke out the BCC kernel tracing tools and ran this one
while running the flaky test case in a loop:
sudo trace -I<kernel src dir>/include/linux/path.h -I<same>/include/linux/dcache.h 'touch_atime(struct path *path) "%s", path->dentry->d_name.name'
Inspecting the results showed that something called "git_thread" was occcasionally updating
the atime on the directory in question!! What on earth...???
The PID shown by trace revealed that this was a background thread for Sublime Text 3.
Sublime now has git integration and shows when there are untracked or modified files. It
seems that it uses a background thread to regularly scan the project directory and look
for new and modified files. This was causing the atime to change.
Even though other developers may not be running ST3, there are any number of reasons why
a background process might recurse through various directories and could cause the atime
to change unexpectedly. Therefore, update the test case so it doesn't fail in such cases.
Closes GH-5553.
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix #79566: Private SHM is not private on Windows
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
We map the POSIX semantics of `IPC_PRIVATE` by creating unnamed file
mapping objects on Windows. While that is not particularly useful for
ext/shmop, which is the only bundled extension which uses `shmget()`,
it may be useful for external extensions.
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix #79561: dns_get_record() fails with DNS_ALL
|
| | | |
| | |
| | |
| | |
| | | |
Since Windows has its own definitions of the `PHP_DNS_*` macros, we
have to use these when registering the PHP constants.
|
| | | |
| | |
| | |
| | |
| | | |
When duplicating user functions with static variables, make sure
that we init a new map ptr slot for the static variables.
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fixed bug #79535
|
| | | |
| | |
| | |
| | |
| | | |
We did not allocate a cache slot for FETCH_CLASS. This is already
fixed on newer PHP versions.
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Disabling postgresql entirely for now, because I can't figure out
how to fix it. Something broke big time with i386 packages on
Azure pipelines.
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Add basic sapi_windows_cp_conv() test
|
| | | |
| | |
| | |
| | | |
This function is lacking any tests so far.
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix #79528: Different object of the same xml between 7.4.5 and 7.4.4
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Revert "Fix #61597: SXE properties may lack attributes and content"
This reverts commit 7c081db885756d7b176a55b90b8746f664d1e042.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Let's go from 32 to 16 parallel jobs. We can reduce this further
if necessary.
Closes GH-5426.
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
On Windows, reusing/sharing of OPcache instances with different
configuration is not necessarily supported, so we have to make that it
does not happen for the clean scripts, by using `$orig_ini_settings`
instead of `$clean_params`.
|
| |\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* 'PHP-7.4' of git.php.net:/php-src:
Fix #79532: sizeof off_t can be wrong
Make 045.phpt busy wait
Revert "Fix #79065: DOM classes do not expose properties to Reflection"
Bump version
Fix #79065: DOM classes do not expose properties to Reflection
Fix #79470: PHP incompatible with 3rd party file system on demand
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We have to actually determine the proper `SIZEOF_OFF_T`.
Interestingly, it is `4` on Windows x64.
We also have to prevent the redefinition in pg_config.h. The clean
solution would likely be to not include pg_config.h at all, but that's
out of scope for BC reasons for now.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The timeout is only real-time based on Windows. Make this use
a busy wait loop instead. If hard_timeout is broken, this will
fail with a run-tests enforced timeout instead.
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 6bc8f7e5a9949b2ba79376abd1ed13d0b4d0ae3c.
This causes an assertion failure in PHPUnit.
|
| | |\ \ \
| | |/ /
| | | |
| | | |
| | | | |
* PHP-7.3:
Bump version
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
We add a `get_properties` handler which complements the already
existing `has_property` and `read_property`handlers.
|
| | |\ \ \
| | |/ /
| | | |
| | | |
| | | | |
* PHP-7.3:
Fix #79470: PHP incompatible with 3rd party file system on demand
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
We add support for Activision HSM (`IO_REPARSE_TAG_ACTIVISION_HSM`) and
VFS for Git (`IO_REPARSE_TAG_PROJFS`). The latter fixes bug #78784.
|
| |/ / /
| | |
| | |
| | | |
called).
|
| | | |
| | |
| | |
| | | |
We have to destroy (un-opened) ZEND_HANDLE_FILENAMEs.
|
| | | | |
|
| |\ \ \
| |/ / |
|
| | | | |
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Add additional preg_match test case
|
| | | |
| | |
| | |
| | |
| | | |
(cherry picked from commit a1a044dcc74379fafb2b63db5ab033aa062aada7
on author's explicit request)
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Partially reverts 846b6479537a112d1ded725e6484e46462048b35: instead of
throwing, this skips uninitialized typed properties when serializing objects.
This makes serialize with __sleep() behave the same as serialize()
without __sleep().
As in the non-__sleep() case, unserialize(serialize($x)) identity
may not be preserved due to replacement of uninitialized/unset
properties with default values. Fixing this will require changes to
the serialization format.
Closes GH-5396.
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix #79503: Memory leak on duplicate metadata
|
| | | |
| | |
| | |
| | |
| | | |
Duplicate metadata can only happen if someone tampers with the phar, so
we can and should treat that as error.
|
| | | | |
|
| | | |
| | |
| | |
| | | |
We backport the slightly modified variant from master.
|
| | | |
| | |
| | |
| | | |
Instead use port 0 to get a free port from the OS.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
When ArrayObject is round-tripped through serialize() and unserialize(),
it forgets any iterator class name which was set using ::setIteratorClass().
Fix that.
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Fix #79491: Search for .user.ini extends up to root dir
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The `start` parameter of `php_cgi_ini_activate_user_config` is supposed
to hold the byte offset of the doc root in the given `path`. However,
the current expression which fixes a potential type incompatibility
will ever only evaluate to zero or one, because it uses the *logical*
and operator (`&&`). Furthermore we notice that subtracting one from
`doc_root_len` is not necessary, so there is even no need for the
`start` parameter at all.
|
| |\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.3:
Apply doc root fix for FPM
|
