| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
PDO::__construct() fails
PDO driver constructors are throwing PdoException without setting
errorInfo, so create a new reusable function that throws exceptions
for PDO and will also set the errorInfo. Use this function in
pdo_mysql, pdo_sqlite, and pdo_pgsql.
|
|
|
|
|
|
|
|
|
|
| |
Different manufacturer models may come with a
different endianness (motorola/intel) format. In
order to avoid a big refactor and a gigantic lookup
table, this commit simply attempts to switch the
endianness and proceed when values are acceptable.
Closes GH-5849.
|
|
|
|
|
|
|
|
| |
Whether the type library is cached is actually irrelevant here; what
matters is that the symbols are imported, and since these are not
cached, we have to import them for every request. And we cannot cache
the symbols, because the import depends on the current codepage, but
the codepage is a `PHP_INI_ALL` setting.
|
|
|
|
|
|
| |
One branch did not release tmp_replace_entry_str.
Also reduce the scope of some variables.
|
| |
|
|
|
|
| |
This was supposed to check mx_list, not weight_list... oops.
|
|
|
|
| |
Only return true from dns_get_mx if we actually found any MX record.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We must not call `zend_list_delete()` in resource closer functions
exposed to userland, because decreasing the refcount there leads to
use-after-free scenarios. In this case, commit 4a42fbb worked for
typical use-cases where `xml_parser_free()` has been called exactly
once for the resource, because there is an internal zval (`->index`)
referencing the same resource which already increased the refcount by
one. However, when `xml_parser_free()` is called multiple times on the
same XML parser resource, the resource would be freed prematurely.
Instead we forcefully close the resource in `xml_parser_free()`. We
also could decrease the refcount of the resource there, but that would
require to call `xml_parser_free()` which is somewhat uncommon, and
would be particularly bad wrt. PHP 8 where that function is a NOP, and
as such doesn't have to be called. So we do no longer increase the
refcount of the resource when copying it to the internal zval, and let
the usualy refcounting semantics take care of the resource destruction.
[1] <http://git.php.net/?p=php-src.git;a=commit;h=4a42fbbbc73aad7427aef5c89974d1833636e082>
|
|
|
|
| |
Closes GH-5940.
|
|
|
|
|
|
|
| |
Fixes the function `next_newline()` in zend_language_scanner.l. The
function now correctly returns a newline_len of 2 for "\r\n".
Closes GH-5944.
|
| |
|
|
|
|
| |
We're inserting src_zval, so that's what we should addref.
|
|
|
|
|
|
|
| |
These systems has two versions of the iovec interface dependent on
compiler flags passed, the legacy version causing little build issue.
Closes GH-5939.
|
| |
|
|\
| |
| |
| |
| |
| | |
* PHP-7.2:
bump version to 7.2.34-dev
Update NEWS
|
| | |
|
| | |
|
| |
| |
| |
| | |
Closes GH-5923.
|
| |
| |
| |
| |
| |
| |
| | |
-e to fail early: ./configure may fail and further errors from make bury
the original problem in the logs.
-x for easier debugging
|
| | |
|
|\ \
| |/
| |
| |
| |
| | |
* PHP-7.2:
Fix #79877: getimagesize function silently truncates after a null byte
Fix #79797: Use of freed hash key in the phar_parse_zipfile function
|
| |
| |
| |
| | |
We have to check for NUL bytes if `getimagesize()` has been called.
|
| |
| |
| |
| | |
We must not use heap memory after we freed it.
|
| |
| |
| |
| |
| | |
Instead of the temporary `rv`, we use the `val_free` which is there for
this purpose.
|
| |
| |
| |
| |
| | |
We fix the erroneous segment size. We also keep the segment pointer at
the allocated address, but increase the position instead.
|
| |
| |
| |
| |
| |
| | |
FETCH_OBJ_R may have an op1 CONST operand, even though it will
always error. We should take this into account when compacting
literals.
|
| | |
|
| |
| |
| |
| | |
Closes GH-5890.
|
| |
| |
| |
| | |
Closes GH-5903.
|
| |
| |
| |
| |
| |
| | |
Instead of storing the mapping base address and the address of
`execute_ex()` in a separate file in the temporary folder, we store
them right at the beginning of the memory mapping.
|
| |
| |
| |
| |
| | |
After resolving reparse points, the path still may be a reparse point;
in that case we have to resolve that reparse point as well.
|
| | |
|
| |
| |
| |
| | |
This reverts commit d5b59b4303642adac91df2c93969a72bc0f5fa7d.
|
| |
| |
| |
| |
| | |
After resolving reparse points, the path still may be a reparse point;
in that case we have to resolve that reparse point as well.
|
| |
| |
| |
| |
| |
| | |
The file extension to mime type mapping *must* not depend on the file
extension's case for case-insensitive file systems, and *should* not
for case-sensitive file systems.
|
|\ \ |
|
| |/
| |
| |
| | |
some log message tunings.
|
| |
| |
| |
| |
| |
| |
| | |
It does not make sense to make assumptions about `PHP_CONFIG_FILE_PATH`
during build time, since that value is never used during run time on
Windows. Since there is no `--with-config-file-path` on Windows
either, we define `PHP_CONFIG_FILE_PATH` as `""`.
|
| |
| |
| |
| |
| |
| | |
This test fails occasionally due to timing issues, because the session
file may have been unlinked by the first `session_start()`'s GC. We
adapt the test expectation to this reality.
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We must not mix multibyte and wide character strings in the
`COAUTHIDENTITY` structure. Using wide character strings throughout
would have the advantage that the remote connection can be established
regardless of the code page of the server, but that would more likely
break BC, so we just drop the wide character string conversion of the
username.
|
| |
| |
| |
| |
| |
| |
| |
| | |
- free handle before return result
- cleaned up remaining usage of MAXPACKET
- update dns_get_mx() to use the same approach
Closes GH-5854.
|
| |
| |
| |
| | |
Closes GH-5853.
|
| |
| |
| |
| | |
It introduced by fixing bug #79830
|
| |
| |
| |
| | |
This also fixes memory error in debug_zval_dump and var_export.
|
| |
| |
| |
| |
| |
| | |
HashTable was reallocated (zend_hash_packed_grow) during php_var_dump, so we should call GC_ADDREF to make SEPARATE_ARRAY work.
Closes GH-5837.
|