| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Closes GH-5418
|
| |
|
|
|
|
| |
Closes GH-5758
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Userland classes that implement Traversable must do so either
through Iterator or IteratorAggregate. The same requirement does
not exist for internal classes: They can implement the internal
get_iterator mechanism, without exposing either the Iterator or
IteratorAggregate APIs. This makes them usable in get_iterator(),
but incompatible with any Iterator based APIs.
A lot of internal classes do this, because exposing the userland
APIs is simply a lot of work. This patch alleviates this issue by
providing a generic InternalIterator class, which acts as an
adapater between get_iterator and Iterator, and can be easily
used by many internal classes. At the same time, we extend the
requirement that Traversable implies Iterator or IteratorAggregate
to internal classes as well.
Closes GH-5216.
|
|
|
|
|
| |
For the common ZVAL_OBJ + GC_ADDREF pattern.
This mirrors the existing ZVAL_STR_COPY API.
|
| |
|
|\
| |
| |
| |
| | |
* PHP-7.4:
Revert "Fix #79065: DOM classes do not expose properties to Reflection"
|
| |
| |
| |
| |
| |
| | |
This reverts commit 6bc8f7e5a9949b2ba79376abd1ed13d0b4d0ae3c.
This causes an assertion failure in PHPUnit.
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
Fix #79065: DOM classes do not expose properties to Reflection
|
| |
| |
| |
| |
| | |
We add a `get_properties` handler which complements the already
existing `has_property` and `read_property`handlers.
|
| |
| |
| |
| | |
Closes GH-5374
|
| |
| |
| |
| | |
Closes GH-5368
|
|\ \
| |/
| |
| |
| | |
* PHP-7.4:
Fix memory leak introduced by fixing bug #78221
|
| |\
| | |
| | |
| | |
| | | |
* PHP-7.3:
Fix memory leak introduced by fixing bug #78221
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We have to free the retrieved text content; to keep the code readable,
we extract a helper function to check for empty nodes. Unfortunately,
we cannot use xmlIsBlankNode(), because that also recognizes whitespace
only text content.
We also make sure to properly handle NULL returns from
xmlNodeGetContent().
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix #78221: DOMNode::normalize() doesn't remove empty text nodes
|
| |\ \
| | |/
| | |
| | |
| | | |
* PHP-7.3:
Fix #78221: DOMNode::normalize() doesn't remove empty text nodes
|
| | |
| | |
| | |
| | |
| | | |
If a text node is not followed by another text node, we remove it, if
its textContent is empty.
|
| | |
| | |
| | |
| | | |
Closes GH-5347
|
| | | |
|
| | |
| | |
| | |
| | | |
Thus fixing an obvious typo.
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It is now only used to signal exceptions for property reads. ERROR
zvals are never returned back to the VM anymore, so there's no
need to check for them when receiving a VAR.
Also return MAY_BE_ERROR, as ERROR is now no longer relevant for
inference.
|
| | |
| | |
| | |
| | | |
Closes GH-4732.
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The following classes were registered in ext/dom but
neither documented nor had any behavior (only test data).
These classes are now removed:
- DOMNameList
- DomImplementationList
- DOMConfiguration
- DomError
- DomErrorHandler
- DOMImplementationSource
- DOMLocator
- DOMUserDataHandler
- DOMTypeInfo
|
|/ /
| |
| |
| | |
insted of zval(s).
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This patch removes the so called local variables defined per
file basis for certain editors to properly show tab width, and
similar settings. These are mainly used by Vim and Emacs editors
yet with recent changes the once working definitions don't work
anymore in Vim without custom plugins or additional configuration.
Neither are these settings synced across the PHP code base.
A simpler and better approach is EditorConfig and fixing code
using some code style fixing tools in the future instead.
This patch also removes the so called modelines for Vim. Modelines
allow Vim editor specifically to set some editor configuration such as
syntax highlighting, indentation style and tab width to be set in the
first line or the last 5 lines per file basis. Since the php test
files have syntax highlighting already set in most editors properly and
EditorConfig takes care of the indentation settings, this patch removes
these as well for the Vim 6.0 and newer versions.
With the removal of local variables for certain editors such as
Emacs and Vim, the footer is also probably not needed anymore when
creating extensions using ext_skel.php script.
Additionally, Vim modelines for setting php syntax and some editor
settings has been removed from some *.phpt files. All these are
mostly not relevant for phpt files neither work properly in the
middle of the file.
|
| | |
|
|/
|
|
|
|
|
|
|
|
| |
RFC: https://wiki.php.net/rfc/typed_properties_v2
This is a squash of PR #3734, which is a squash of PR #3313.
Co-authored-by: Bob Weinand <bobwei9@hotmail.com>
Co-authored-by: Joe Watkins <krakjoe@php.net>
Co-authored-by: Dmitry Stogov <dmitry@zend.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.
In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.
This patch simplifies handling of $Id$ keywords by removing them since
they are not used anymore.
|
| |
|
| |
|
|
|
|
| |
where we sure about string persistence.
|
| |
|
|\
| |
| |
| |
| | |
* PHP-7.2:
Remove duplicated assignment
|
| |\
| | |
| | |
| | |
| | | |
* PHP-7.1:
Remove duplicated assignment
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
Now that they are not memset, they need to be explicitly intialized,
as zend_objects_clone_members() destroys the old property values
first.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Using ecalloc() to create objects is expensive, because the
dynamic-size memset() is unreasonably slow. Make sure we only
zero the main object structure with known size, as the properties
are intialized separately anyway.
Technically we do not need to zero the embedded zend_object
structure either, but as long as the memset argument is constant,
a couple more bytes don't really matter.
|
| | |
| | |
| | |
| | | |
into SHM)
|
| | |
| | |
| | |
| | |
| | |
| | | |
Prohibit direct update of GC_REFCOUNT(), GC_SET_REFCOUNT(), GC_ADDREF() and GC_DELREF() shoukf be instead.
Added mactros to validate reference-counting (disabled for now).
These macros are going to be used to eliminate race-condintions during reference-counting on data shared between threads.
|
|/ /
| |
| |
| | |
converted into macros calling zend_new_array(). They are not functions anymore and don't return any values.
|
| | |
|