| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | | |
Due to a bug in the tidy script, most tests did not actually get
reindented...
|
| | |
| | |
| | |
| | |
| | |
| | | |
Reindent ext/mysqli tests on PHP-7.4, so they match with the
indentation on PHP-8.0. Otherwise merging test changes across
branches is very unpleasant.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix #80312: change default engine from MyISAM to InnoDB in tests
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Change mysqli and pdo_mysql tests configuration to use by default
InnoDB instead of MyISAM.
Closes GH-6405.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Handle errors during next_result()
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
All other leftovers of this feature have been dropped in PHP 8,
so we should remove the property as well.
Closes GH-6407.
|
| | |
| | |
| | |
| | | |
Closes GH-6390.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix bug #72413: Segfault with get_result and PS cursors
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We cannot simply switch to use_result here, because the fetch_row
methods in get_result mode and in use_result/store_result mode
are different: In one case it accepts a statement, in the other
a return value zval. Thus, doing a switch to use_result results
in a segfault when trying to fetch a row.
Actually supporting get_result with cursors would require adding
cursor support in mysqlnd_result, not just mysqlnd_ps. That would
be a significant amount of effort and, given the age of the issue,
does not appear to be particularly likely to happen soon.
As such, we simply generate an error when using get_result()
with cursors, which is much better than causing a segfault.
Instead, parameter binding needs to be used.
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | | |
* PHP-7.4:
Handle mysqli errors in more cases
Sync test with master
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Report errors autocommit, commit, rollback and mysqli_stmt_attr_set.
Additionally, copy the error from conn to stmt when preparing fails,
so these errors are also handled by mysqli_stmt_prepare.
Closes GH-6157.
|
| | |
| | |
| | |
| | |
| | | |
Sync ext/mysqli/tests/mysqli_report.phpt with PHP-8.0/master, as
the current difference in indentation makes it hard to merge.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix bug #79375
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Make sure deadlock errors are properly propagated and reports in
a number of places in mysqli and PDO MySQL.
This also fixes a memory and a segfault that can occur under these
conditions.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This error condition should not actually be reachable, but change
it to be consistent with the other ones.
Also fix a memory leak.
Closes GH-6340.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Make [] acceptable both for classes without constructors and
classes with a constructor that takes no arguments.
Closes GH-6336.
|
| | |
| | |
| | |
| | | |
Closes GH-6335
|
| | |
| | |
| | |
| | | |
Refs GH-6172.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The constructor was already effectively inaccessible (protected
on a final class). This just makes it more obvious and removes
the implementation in favor of directly throwing.
Per the removed test, this was an unfinished feature, and I don't
think it makes a lot of sense to finish it -- the
mysqli_stmt::get_warnings() interface makes more sense than
direct construction.
Closes GH-6208.
|
| | |
| | |
| | |
| | | |
Closes GH-6172.
|
| | |
| | |
| | |
| | | |
Closes GH-6211
|
| | |
| | |
| | |
| | | |
Closes GH-6173
|
| | | |
|
| | |
| | |
| | |
| | | |
And drop the last remaining uses of it.
|
| | |
| | |
| | |
| | |
| | |
| | | |
is provided
Closes GH-6142.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Use MyISAM engine for new test
|
| |\ \
| | |/
| | |
| | |
| | | |
* PHP-7.3:
Use MyISAM engine for new test
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Travis on 7.3 is showing this error:
> The size of BLOB/TEXT data inserted in one transaction is greater
> than 10% of redo log size. Increase the redo log size using
> innodb_log_file_size.
Force MyISAM engine to avoid this.
|
| | |
| | |
| | |
| | |
| | | |
This should fix most of the remaining issues with tabs and spaces
being mixed in tests.
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | | |
* PHP-7.4:
Fix bug #80107: Handling of large compressed packets
Bug #80107 Add test for mysqli_query() fails for ~16 MB long query when compression is enabled
|
| |\ \
| | |/
| | |
| | |
| | |
| | | |
* PHP-7.3:
Fix bug #80107: Handling of large compressed packets
Bug #80107 Add test for mysqli_query() fails for ~16 MB long query when compression is enabled
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There's two layers of packet splitting going on. First, packets
need to be split into having a payload of exactly 2^24-1 bytes or
being the last packet. If the split packet has size between 2^24-5
and 2^24-1 bytes, the compressed packets also needs to be split,
though the choice of split doesn't matter here. I'm splitting off
the first 8192 bytes, as that's what I observe libmysqlclient to be
doing.
|
| | |
| | |
| | |
| | | |
compression is enabled
|
| | | |
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix mysqli_release_savepoint() on mysqlnd
|
| |\ \
| | |/
| | |
| | |
| | | |
* PHP-7.3:
Fix mysqli_release_savepoint() on mysqlnd
|
| | |
| | |
| | |
| | | |
mysqli_release_savepoint() was not actually releasing a savepoint...
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | | |
Aligning the behaviour of fetch_field and field_seek.
|
| | |
| | |
| | |
| | |
| | |
| | | |
"cannot be used in MYSQLI_USE_RESULT mode" sounds more correct than "cannot be used with MYSQLI_USE_RESULT"
Closes GH-6137.
|
| | |
| | |
| | |
| | | |
follow-up to 7a95e94 for MySQL < 5.6
|
| | |
| | |
| | |
| | | |
Closes GH-5803
|
| | | |
|
| | |
| | |
| | |
| | | |
Closes GH-6110
|
| | |
| | |
| | |
| | | |
Closes GH-5999
|
| | |
| | |
| | |
| | |
| | |
| | | |
We have to ensure that the attempted connection to the MySQL server
fails, and do that by passing an unknown host instead of falling back
to localhost.
|
| | |
| | |
| | |
| | |
| | | |
The warning message is rather different there, but since that is
irrelevant for this test case, we just suppress the warning.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There is an edge case in constructor behavior where we can end up
with mysql->mysql being NULL (rather than mysql itself already being
NULL). I think that ultimately that's a bug in the constructor code,
and we should probably be destroying the outer structure on
construction failure as well. However it's pretty hard to unravel
with when considering all the construction permutations.
|