| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
We fix (hopefully) all instances of:
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4005>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4024>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4028>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4047>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4087>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4090>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4273>
* <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4312>
`zend_llist_add_element()` and `zend_llist_prepend_element()` now
explicitly expect a *const* pointer.
We use the macro `ZEND_VOIDP()` instead of a `(void*)` cast to suppress
C4090; this should prevent accidential removal of the cast by
clarifying the intention, and makes it easier to remove the casts if
the issue[1] will be resolved sometime.
[1] <https://developercommunity.visualstudio.com/content/problem/390711/c-compiler-incorrect-propagation-of-const-qualifie.html>
|
| | |
| | |
| | |
| | |
| | | |
Instead directly define MYSQLND_COMPRESSION_ENABLED. This also
matches what config.w32 does.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
mysqlnd: Remove unnecessary check for HAVE_ZLIB
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If MYSQLND_COMPRESSION_WANTED is set, we already guarantee that
zlib is linked, but don't necessarily set HAVE_ZLIB.
Closes GH-5658.
|
| | | |
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix #79596: MySQL FLOAT truncates to int some locales
|
| |\ \
| | |/
| | |
| | |
| | | |
* PHP-7.3:
Fix #79596: MySQL FLOAT truncates to int some locales
|
| | |
| | |
| | |
| | |
| | | |
We must not do locale aware float to string conversion here; instead
we using our `snprintf()` implementation with the `F` specifier.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
These are always available as of C99.
Closes GH-5323
Co-authored-by: "Christoph M. Becker" <cmbecker69@gmx.de>
|
| | | |
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix MySQL local infile / attr handling on big endian systems
|
| |\ \
| | |/
| | |
| | |
| | | |
* PHP-7.3:
Fix MySQL local infile / attr handling on big endian systems
|
| | |
| | |
| | |
| | |
| | |
| | | |
Make sure pointer types match what is used by libmysql everywhere.
Closes GH-5380.
|
| | |
| | |
| | |
| | |
| | | |
The implementation is broken (syntactically). As it's not used
anyway, I'm just dropping it instead.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix incorrect free for last_message
|
| |\ \
| | |/
| | |
| | |
| | | |
* PHP-7.3:
Fix incorrect free for last_message
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In commit a7305eb539596e175bd6c3ae9a20953358c5d677 the last_message
field of the connection object was changed to be always non-persistent.
But there is a place on change_user path that still treats it
depending on conn->persistent flag. This will cause PHP crash after
com_change_user success when there is last_message set
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix leak on Windows as well
|
| | |
| | |
| | |
| | | |
Cf. <http://git.php.net/?p=php-src.git;a=commit;h=db08ef0d3274b239a6b9e68d71d02bb6acb71d82>
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix RSA memory leak in mysqlnd auth
|
| | | |
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | | |
* PHP-7.4:
Native Windows support for mysqlnd sha256 authentification
Abstract over crypto operations
|
| | |
| | |
| | |
| | | |
We implement that on top of Cryptography API: Next Generation (CNG).
|
| | | |
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Don't use VLA in mysqlnd auth
|
| | |
| | |
| | |
| | |
| | | |
We use alloca instead of VLA. This should also allow building
this code on Windows.
|
| | |
| | |
| | |
| | |
| | | |
Explicitly initialize to NULL the unused pointers to preserve
ABI forwards compatibility.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix #79172: STRUCT_OFFSET() relies on undefined behavior
|
| | |
| | |
| | |
| | |
| | | |
Since this pattern is understood by compilers, not a real issue, but
certainly cleaner this way.
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | | |
* PHP-7.4:
Fixed bug #79011
Fix memory leaks in mysqlnd debug functionality
|
| | |
| | |
| | |
| | |
| | |
| | | |
auth_plugin_data_len here is 21, including the trailing null byte.
Directly use SCRAMBLE_LENGTH instead. Also add a sanity check that
the provided scramble is long enough.
|
| | | |
|
| | |
| | |
| | |
| | | |
Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.
|
| | | |
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix #79084: mysqlnd may fetch wrong column indexes with MYSQLI_BOTH
|
| |\ \
| | |/
| | |
| | |
| | | |
* PHP-7.3:
Fix #79084: mysqlnd may fetch wrong column indexes with MYSQLI_BOTH
|
| | |
| | |
| | |
| | |
| | |
| | | |
Column names can be numeric strings, so we have to make sure to insert
the column values with the appropriate numeric keys, instead of adding
them.
|
|\ \ \
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* PHP-7.4:
Handle empty password fast path in caching_sha2_password
Handle error response during caching_sha2_password auth
Add support for caching_sha2_password in change user authentication
Fix unix socket check during caching_sha2_password
Support auth switch request during caching sha2 auth
|
| | |
| | |
| | |
| | |
| | |
| | | |
If an empty password is used, no additional packets are exchanged
during caching_sha2_password auth. We're only looking for an
OK/ERR response.
|
| | |
| | |
| | |
| | | |
In particular, this fixes handling of expired passwords.
|
| | |
| | |
| | |
| | | |
Same as for connection handshakes.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The fact that conn->unix_socket is set does not mean that a Unix
socket is actually in use -- this member is set in a default
configuration.
Instead check whether a unix_socket stream ops is used.
|
| | | |
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Free RSA public key in mysqlnd sha256 auth
|
| | |
| | |
| | |
| | | |
Not sure why this only started showing up as a leak now.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Fix bug #78823: add zlib library to mysqlnd
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The problem is newer binutils will no longer default to --copy-dt-needed-entries but use --no-copy-dt-needed-entries instead. So all libraries needed *must* be provided.
Workarounds (either one works)
1) Add "-Wl,--copy-dt-needed-entries" to LDFLAGS to bring back the old behavior of the linker
2) Add "-lz" to list of libraries to be added
In "ext/mysqlnd/mysqlnd_protocol_frame_codec.c" when the "zlib.h" header is included should also trigger adding '-lz' to the list of libraries.
|
|\ \ \
| |/ /
| | |
| | |
| | | |
* PHP-7.4:
Remove dead code `ext/mysqlnd/mysqlnd_net.c`.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I believe this code has been dead since 05c5e05 (2015) now replaced
by `ext/mysqlnd/mysqlnd_vio.c`.
Closes GH-4888.
|
|/ /
| |
| |
| | |
Closes GH-4732.
|