summaryrefslogtreecommitdiff
path: root/ext/mysqlnd
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Fix MSVC level 1 (severe) warningsChristoph M. Becker2020-06-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We fix (hopefully) all instances of: * <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4005> * <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4024> * <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4028> * <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4047> * <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4087> * <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4090> * <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4273> * <https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4312> `zend_llist_add_element()` and `zend_llist_prepend_element()` now explicitly expect a *const* pointer. We use the macro `ZEND_VOIDP()` instead of a `(void*)` cast to suppress C4090; this should prevent accidential removal of the cast by clarifying the intention, and makes it easier to remove the casts if the issue[1] will be resolved sometime. [1] <https://developercommunity.visualstudio.com/content/problem/390711/c-compiler-incorrect-propagation-of-const-qualifie.html>
* | | Remove MYSQLND_COMPRESSION_WANTED defineNikita Popov2020-06-042-5/+1
| | | | | | | | | | | | | | | Instead directly define MYSQLND_COMPRESSION_ENABLED. This also matches what config.w32 does.
* | | Merge branch 'PHP-7.4'Nikita Popov2020-06-041-1/+1
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: mysqlnd: Remove unnecessary check for HAVE_ZLIB
| * | mysqlnd: Remove unnecessary check for HAVE_ZLIBtalyz2020-06-041-1/+1
| | | | | | | | | | | | | | | | | | | | | If MYSQLND_COMPRESSION_WANTED is set, we already guarantee that zlib is linked, but don't necessarily set HAVE_ZLIB. Closes GH-5658.
* | | Fix [-Wundef] warning in MySQLnd extensionGeorge Peter Banyard2020-05-187-9/+9
| | |
* | | Merge branch 'PHP-7.4'Christoph M. Becker2020-05-151-2/+2
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Fix #79596: MySQL FLOAT truncates to int some locales
| * | Merge branch 'PHP-7.3' into PHP-7.4Christoph M. Becker2020-05-151-2/+2
| |\ \ | | |/ | | | | | | | | | * PHP-7.3: Fix #79596: MySQL FLOAT truncates to int some locales
| | * Fix #79596: MySQL FLOAT truncates to int some localesChristoph M. Becker2020-05-151-2/+2
| | | | | | | | | | | | | | | We must not do locale aware float to string conversion here; instead we using our `snprintf()` implementation with the `F` specifier.
* | | Drop unnecessary stdint and inttypes header checksGeorge Peter Banyard2020-04-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | These are always available as of C99. Closes GH-5323 Co-authored-by: "Christoph M. Becker" <cmbecker69@gmx.de>
* | | Fix [-Wjump-misses-init] warning in MySQL new driver extensionGeorge Peter Banyard2020-04-181-1/+2
| | |
* | | Merge branch 'PHP-7.4'Nikita Popov2020-04-161-5/+5
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Fix MySQL local infile / attr handling on big endian systems
| * | Merge branch 'PHP-7.3' into PHP-7.4Nikita Popov2020-04-161-5/+5
| |\ \ | | |/ | | | | | | | | | * PHP-7.3: Fix MySQL local infile / attr handling on big endian systems
| | * Fix MySQL local infile / attr handling on big endian systemsguirish2020-04-161-5/+5
| | | | | | | | | | | | | | | | | | Make sure pointer types match what is used by libmysql everywhere. Closes GH-5380.
* | | Remove int6store()Nikita Popov2020-04-141-17/+0
| | | | | | | | | | | | | | | The implementation is broken (syntactically). As it's not used anyway, I'm just dropping it instead.
* | | Merge branch 'PHP-7.4'Nikita Popov2020-04-031-1/+1
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Fix incorrect free for last_message
| * | Merge branch 'PHP-7.3' into PHP-7.4Nikita Popov2020-04-031-1/+1
| |\ \ | | |/ | | | | | | | | | * PHP-7.3: Fix incorrect free for last_message
| | * Fix incorrect free for last_messageQianqian Bu2020-04-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | In commit a7305eb539596e175bd6c3ae9a20953358c5d677 the last_message field of the connection object was changed to be always non-persistent. But there is a place on change_user path that still treats it depending on conn->persistent flag. This will cause PHP crash after com_change_user success when there is last_message set
* | | Merge branch 'PHP-7.4'Christoph M. Becker2020-03-231-0/+5
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Fix leak on Windows as well
| * | Fix leak on Windows as wellChristoph M. Becker2020-03-231-0/+5
| | | | | | | | | | | | Cf. <http://git.php.net/?p=php-src.git;a=commit;h=db08ef0d3274b239a6b9e68d71d02bb6acb71d82>
* | | Merge branch 'PHP-7.4'Nikita Popov2020-03-231-0/+3
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Fix RSA memory leak in mysqlnd auth
| * | Fix RSA memory leak in mysqlnd authNikita Popov2020-03-231-0/+3
| | |
* | | Merge branch 'PHP-7.4'Christoph M. Becker2020-03-022-61/+209
|\ \ \ | |/ / | | | | | | | | | | | | * PHP-7.4: Native Windows support for mysqlnd sha256 authentification Abstract over crypto operations
| * | Native Windows support for mysqlnd sha256 authentificationChristoph M. Becker2020-03-022-0/+132
| | | | | | | | | | | | We implement that on top of Cryptography API: Next Generation (CNG).
| * | Abstract over crypto operationsChristoph M. Becker2020-03-021-61/+77
| | |
* | | Merge branch 'PHP-7.4'Nikita Popov2020-02-182-9/+8
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Don't use VLA in mysqlnd auth
| * | Don't use VLA in mysqlnd authNikita Popov2020-02-182-9/+8
| | | | | | | | | | | | | | | We use alloca instead of VLA. This should also allow building this code on Windows.
* | | Fix [-Wmissing-field-initializers] compiler warning in mysqlnd_result.cGeorge Peter Banyard2020-02-101-1/+6
| | | | | | | | | | | | | | | Explicitly initialize to NULL the unused pointers to preserve ABI forwards compatibility.
* | | Merge branch 'PHP-7.4'Christoph M. Becker2020-01-281-1/+1
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Fix #79172: STRUCT_OFFSET() relies on undefined behavior
| * | Fix #79172: STRUCT_OFFSET() relies on undefined behaviorChristoph M. Becker2020-01-281-1/+1
| | | | | | | | | | | | | | | Since this pattern is understood by compilers, not a real issue, but certainly cleaner this way.
* | | Merge branch 'PHP-7.4'Nikita Popov2020-01-242-2/+12
|\ \ \ | |/ / | | | | | | | | | | | | * PHP-7.4: Fixed bug #79011 Fix memory leaks in mysqlnd debug functionality
| * | Fixed bug #79011Nikita Popov2020-01-241-1/+7
| | | | | | | | | | | | | | | | | | auth_plugin_data_len here is 21, including the trailing null byte. Directly use SCRAMBLE_LENGTH instead. Also add a sanity check that the provided scramble is long enough.
| * | Fix memory leaks in mysqlnd debug functionalityNikita Popov2020-01-241-1/+5
| | |
* | | Make error messages more consistent by fixing capitalizationMáté Kocsis2020-01-171-1/+1
| | | | | | | | | | | | Closes GH-5066 As a first step, let's capitalize their initial letter when it is applicable.
* | | Fix #78880: Final spelling fixesMáté Kocsis2020-01-162-2/+2
| | |
* | | Merge branch 'PHP-7.4'Christoph M. Becker2020-01-131-6/+9
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Fix #79084: mysqlnd may fetch wrong column indexes with MYSQLI_BOTH
| * | Merge branch 'PHP-7.3' into PHP-7.4Christoph M. Becker2020-01-131-6/+9
| |\ \ | | |/ | | | | | | | | | * PHP-7.3: Fix #79084: mysqlnd may fetch wrong column indexes with MYSQLI_BOTH
| | * Fix #79084: mysqlnd may fetch wrong column indexes with MYSQLI_BOTHChristoph M. Becker2020-01-131-6/+9
| | | | | | | | | | | | | | | | | | Column names can be numeric strings, so we have to make sure to insert the column values with the appropriate numeric keys, instead of adding them.
* | | Merge branch 'PHP-7.4'Nikita Popov2019-12-276-20/+111
|\ \ \ | |/ / | | | | | | | | | | | | | | | | | | | | | * PHP-7.4: Handle empty password fast path in caching_sha2_password Handle error response during caching_sha2_password auth Add support for caching_sha2_password in change user authentication Fix unix socket check during caching_sha2_password Support auth switch request during caching sha2 auth
| * | Handle empty password fast path in caching_sha2_passwordNikita Popov2019-12-271-1/+6
| | | | | | | | | | | | | | | | | | If an empty password is used, no additional packets are exchanged during caching_sha2_password auth. We're only looking for an OK/ERR response.
| * | Handle error response during caching_sha2_password authNikita Popov2019-12-273-6/+24
| | | | | | | | | | | | In particular, this fixes handling of expired passwords.
| * | Add support for caching_sha2_password in change user authenticationNikita Popov2019-12-272-0/+16
| | | | | | | | | | | | Same as for connection handshakes.
| * | Fix unix socket check during caching_sha2_passwordNikita Popov2019-12-272-7/+11
| | | | | | | | | | | | | | | | | | | | | | | | The fact that conn->unix_socket is set does not mean that a Unix socket is actually in use -- this member is set in a default configuration. Instead check whether a unix_socket stream ops is used.
| * | Support auth switch request during caching sha2 authNikita Popov2019-12-274-12/+60
| | |
* | | Merge branch 'PHP-7.4'Nikita Popov2019-12-111-0/+1
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Free RSA public key in mysqlnd sha256 auth
| * | Free RSA public key in mysqlnd sha256 authNikita Popov2019-12-111-0/+1
| | | | | | | | | | | | Not sure why this only started showing up as a leak now.
* | | Merge branch 'PHP-7.4'Nikita Popov2019-12-051-0/+3
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Fix bug #78823: add zlib library to mysqlnd
| * | Fix bug #78823: add zlib library to mysqlndArjen de Korte2019-12-051-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The problem is newer binutils will no longer default to --copy-dt-needed-entries but use --no-copy-dt-needed-entries instead. So all libraries needed *must* be provided. Workarounds (either one works) 1) Add "-Wl,--copy-dt-needed-entries" to LDFLAGS to bring back the old behavior of the linker 2) Add "-lz" to list of libraries to be added In "ext/mysqlnd/mysqlnd_protocol_frame_codec.c" when the "zlib.h" header is included should also trigger adding '-lz' to the list of libraries.
* | | Merge branch 'PHP-7.4'Nikita Popov2019-11-041-1222/+0
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Remove dead code `ext/mysqlnd/mysqlnd_net.c`.
| * | Remove dead code `ext/mysqlnd/mysqlnd_net.c`.Adam Saponara2019-11-041-1224/+0
| | | | | | | | | | | | | | | | | | | | | I believe this code has been dead since 05c5e05 (2015) now replaced by `ext/mysqlnd/mysqlnd_vio.c`. Closes GH-4888.
* | | Remove mention of PHP major version in Copyright headersGabriel Caruso2019-09-2548-96/+0
|/ / | | | | | | Closes GH-4732.