summaryrefslogtreecommitdiff
path: root/ext/pdo_pgsql
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Use RETURN_THROWS() during ZPP in most of the extensionsMáté Kocsis2019-12-311-7/+7
| | | | | | | | | | | | Except for some bigger ones: reflection, sodium, spl
* | | Merge branch 'PHP-7.4'Nikita Popov2019-12-201-1/+1
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Fix #78982: pdo_pgsql returns dead persistent connection
| * | Merge branch 'PHP-7.3' into PHP-7.4Nikita Popov2019-12-201-1/+1
| |\ \ | | |/ | | | | | | | | | * PHP-7.3: Fix #78982: pdo_pgsql returns dead persistent connection
| | * Fix #78982: pdo_pgsql returns dead persistent connectionSATO Kentaro2019-12-201-1/+1
| | | | | | | | | | | | Call PQconsumeInput() before PQstatus() to update the status.
* | | Merge branch 'PHP-7.4'Nikita Popov2019-12-201-2/+10
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Fix #78980: pgsqlGetNotify() overlooks dead connection
| * | Merge branch 'PHP-7.3' into PHP-7.4Nikita Popov2019-12-201-2/+10
| |\ \ | | |/ | | | | | | | | | * PHP-7.3: Fix #78980: pgsqlGetNotify() overlooks dead connection
| | * Fix #78980: pgsqlGetNotify() overlooks dead connectionSATO Kentaro2019-12-201-2/+10
| | | | | | | | | | | | pgsqlGetNotify() didn't check result of PQconsumeInput().
* | | Merge branch 'PHP-7.4'Christoph M. Becker2019-12-191-1/+1
|\ \ \ | |/ / | | | | | | | | | * PHP-7.4: Fix #78983: pdo_pgsql config.w32 cannot find libpq-fe.h
| * | Merge branch 'PHP-7.3' into PHP-7.4Christoph M. Becker2019-12-191-1/+1
| |\ \ | | |/ | | | | | | | | | * PHP-7.3: Fix #78983: pdo_pgsql config.w32 cannot find libpq-fe.h
| | * Fix #78983: pdo_pgsql config.w32 cannot find libpq-fe.hSATO Kentaro2019-12-191-1/+1
| | | | | | | | | | | | When configured with a path specified.
* | | Add missing ZPP checksMáté Kocsis2019-11-011-0/+4
| | | | | | | | | | | | Closes GH-4878.
* | | Cleanup return values when parameter parsing is unsuccessfulMáté Kocsis2019-10-301-3/+3
| | |
* | | Remove mention of PHP major version in Copyright headersGabriel Caruso2019-09-255-10/+0
|/ / | | | | | | Closes GH-4732.
* | Fix PDO pgsql memory leak with scrollable cursorsNikita Popov2019-09-091-1/+1
| |
* | Fix detection of pg_config.hChristoph M. Becker2019-08-071-1/+1
| | | | | | | | | | pg_config.h is supposed to be placed right besides libpq-fe.h, so we should check the same paths.
* | Skip test if ext/json is not availableChristoph M. Becker2019-08-071-0/+1
| | | | | | | | Otherwise the test fails.
* | Cleanup of remaining E_STRICT in testsGeorge Peter Banyard2019-07-231-1/+1
| |
* | Fix FR #71885 (Allow escaping question mark placeholders)Matteo Beccati2019-07-223-23/+126
| |
* | Report errors from stream read and write operationsNikita Popov2019-07-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The php_stream_read() and php_stream_write() functions now return an ssize_t value, with negative results indicating failure. Functions like fread() and fwrite() will return false in that case. As a special case, EWOULDBLOCK and EAGAIN on non-blocking streams should not be regarded as error conditions, and be reported as successful zero-length reads/writes instead. The handling of EINTR remains unclear and is internally inconsistent (e.g. some code-paths will automatically retry on EINTR, while some won't). I'm landing this now to make sure the stream wrapper ops API changes make it into 7.4 -- however, if the user-facing changes turn out to be problematic we have the option of clamping negative returns to zero in php_stream_read() and php_stream_write() to restore the old behavior in a relatively non-intrusive manner.
* | Remove conditional calls of always available macrosPeter Kokot2019-07-141-4/+1
| | | | | | | | | | | | | | These checks were once relevant for these extensions in PECL and PHP versions without availability of the checked macros. Closes GH-4405
* | Simplify PHP_CHECK_PDO_INCLUDES callsPeter Kokot2019-07-081-16/+1
| | | | | | | | | | | | | | Conditional checks were once used for backwards compatibility with phpize from PHP versions that didn't have this macro call yet. Closes GH-4376
* | Fix type mismatch in two get_col callbacksNikita Popov2019-06-121-1/+1
| |
* | Allow exceptions in __toString()Nikita Popov2019-06-051-1/+4
| | | | | | | | | | | | | | | | | | | | RFC: https://wiki.php.net/rfc/tostring_exceptions And convert some object to string conversion related recoverable fatal errors into Error exceptions. Improve exception safety of internal code performing string conversions.
* | Normalize comments in *nix build system m4 filesPeter Kokot2019-05-121-2/+0
| | | | | | | | | | | | | | | | | | Normalization include: - Use dnl for everything that can be ommitted when configure is built in favor of the shell comment character # which is visible in the output. - Line length normalized to 80 columns - Dots for most of the one line sentences - Macro definitions include similar pattern header comments now
* | Disable PACKAGE_* preprocessor symbolsPeter Kokot2019-04-132-11/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Autoconf defines PACKAGE_* symbols: - PACKAGE_NAME - PACKAGE_VERSION - PACKAGE_TARNAME - PACKAGE_STRING - PACKAGE_BUGREPORT - PACKAGE_URL and appends them to the generated config.h.in files. With AC_INIT change via afd52f9d9986d92dd0c63832a07ab1a16bf11d53 where package version, URL, bug report location and similar meta data are defined, these preprocessor macros are then non empty strings in the generated configuration header file. When using phpize, PHP shares the config files in extensions, warnings of redefined macros appear, such as: - `warning: 'PACKAGE_NAME' macro redefined` This patch now disables these non utilized symbols in the generated config header files. Better practice would be to include only API specific headers where needed but this would require even more refactorings. Some extensions such as pcre, pgsql, and pdo_pgsql solve this issue by undefining some of these symbols before including the library configuration headers in the code also. Because these symbols can be defined by any library which uses Autotools. Additionally, the unused PACKAGE_* symbols were cleaned for the bundled libmbfl library and with this patch not needed undef code removed.
* | Merge branch 'PHP-7.3' into PHP-7.4Christoph M. Becker2019-04-123-7/+7
|\ \ | |/ | | | | | | * PHP-7.3: Fix tests wrt. internationalization
| * Merge branch 'PHP-7.2' into PHP-7.3Christoph M. Becker2019-04-123-7/+7
| |\ | | | | | | | | | | | | * PHP-7.2: Fix tests wrt. internationalization
| | * Fix tests wrt. internationalizationChristoph M. Becker2019-04-123-7/+7
| | |
| | * Sync leading and final newlines in *.phpt sectionsPeter Kokot2018-10-1512-14/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds missing newlines, trims multiple redundant final newlines into a single one, and trims redundant leading newlines in all *.phpt sections. According to POSIX, a line is a sequence of zero or more non-' <newline>' characters plus a terminating '<newline>' character. [1] Files should normally have at least one final newline character. C89 [2] and later standards [3] mention a final newline: "A source file that is not empty shall end in a new-line character, which shall not be immediately preceded by a backslash character." Although it is not mandatory for all files to have a final newline fixed, a more consistent and homogeneous approach brings less of commit differences issues and a better development experience in certain text editors and IDEs. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 [2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2 [3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
| | * Trim trailing whitespace in *.phptPeter Kokot2018-10-143-4/+4
| | |
| | * Trim trailing whitespace in source code filesPeter Kokot2018-10-131-1/+1
| | |
| * | Sync leading and final newlines in *.phpt sectionsPeter Kokot2018-10-1512-14/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds missing newlines, trims multiple redundant final newlines into a single one, and trims redundant leading newlines in all *.phpt sections. According to POSIX, a line is a sequence of zero or more non-' <newline>' characters plus a terminating '<newline>' character. [1] Files should normally have at least one final newline character. C89 [2] and later standards [3] mention a final newline: "A source file that is not empty shall end in a new-line character, which shall not be immediately preceded by a backslash character." Although it is not mandatory for all files to have a final newline fixed, a more consistent and homogeneous approach brings less of commit differences issues and a better development experience in certain text editors and IDEs. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 [2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2 [3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
| * | Trim trailing whitespace in *.phptPeter Kokot2018-10-143-4/+4
| | |
* | | Replace dirname(__FILE__) by __DIR__ in testsFabien Villepinte2019-03-1535-149/+149
| | |
* | | Add AS_HELP_STRING to *nix build configure optionsPeter Kokot2019-03-071-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | The Autoconf's default AS_HELP_STRING macro can properly format help strings [1] so watching out if columns are aligned manually is not anymore. [1] https://www.gnu.org/software/autoconf/manual/autoconf.html#Pretty-Help-Strings
* | | Implement fine-grained conflict handlingNikita Popov2019-02-201-0/+1
| | | | | | | | | | | | | | | | | | Tests can specify conflict keys, either in --CONFLICTS-- or a per-directory CONFLICTS file. Non-conflicting tests may be run in parallel.
* | | Remove local variablesPeter Kokot2019-02-0314-55/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch removes the so called local variables defined per file basis for certain editors to properly show tab width, and similar settings. These are mainly used by Vim and Emacs editors yet with recent changes the once working definitions don't work anymore in Vim without custom plugins or additional configuration. Neither are these settings synced across the PHP code base. A simpler and better approach is EditorConfig and fixing code using some code style fixing tools in the future instead. This patch also removes the so called modelines for Vim. Modelines allow Vim editor specifically to set some editor configuration such as syntax highlighting, indentation style and tab width to be set in the first line or the last 5 lines per file basis. Since the php test files have syntax highlighting already set in most editors properly and EditorConfig takes care of the indentation settings, this patch removes these as well for the Vim 6.0 and newer versions. With the removal of local variables for certain editors such as Emacs and Vim, the footer is also probably not needed anymore when creating extensions using ext_skel.php script. Additionally, Vim modelines for setting php syntax and some editor settings has been removed from some *.phpt files. All these are mostly not relevant for phpt files neither work properly in the middle of the file.
* | | Remove yearly range from copyright noticeZeev Suraski2019-01-305-5/+5
| | |
* | | ext/pdo_pgsql: drop unneeded codeEli Schwartz2018-12-091-14/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | This check was added in 0db373883fb073e1773823b236daaf0d3f5a0491 and greps for a private implementation detail of the postgres headers, removed in https://github.com/postgres/postgres/commit/3c4768d0d17d4569f2417aa5741e0317404b6c45 It hasn't worked as intended for 12 years, and can safely be assumed to not be needed.
* | | Clean up unnecessary ternary expressions and simplify some returnsGabriel Caruso2018-12-031-1/+1
| | | | | | | | | | | | | | | | | | | | | - Simplify conditions - Use ZEND_HASH_APPLY_* instead of hard-coded booleans - Use ZEND_NORMALIZE_BOOL - Drop sign in favor of ZEND_NORMALIZE_BOOL
* | | Use ZEND_THIS macro to hide implementation details in extensions code.Dmitry Stogov2018-11-151-10/+10
| | |
* | | Replace getThis() by EX(This), when additional check is not necessary.Dmitry Stogov2018-11-141-10/+10
| | |
* | | Sync leading and final newlines in *.phpt sectionsPeter Kokot2018-10-1512-14/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch adds missing newlines, trims multiple redundant final newlines into a single one, and trims redundant leading newlines in all *.phpt sections. According to POSIX, a line is a sequence of zero or more non-' <newline>' characters plus a terminating '<newline>' character. [1] Files should normally have at least one final newline character. C89 [2] and later standards [3] mention a final newline: "A source file that is not empty shall end in a new-line character, which shall not be immediately preceded by a backslash character." Although it is not mandatory for all files to have a final newline fixed, a more consistent and homogeneous approach brings less of commit differences issues and a better development experience in certain text editors and IDEs. [1] http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206 [2] https://port70.net/~nsz/c/c89/c89-draft.html#2.1.1.2 [3] https://port70.net/~nsz/c/c99/n1256.html#5.1.1.2
* | | Trim trailing whitespace in *.phptPeter Kokot2018-10-143-3/+3
| | |
* | | Trim trailing whitespace in testsGabriel Caruso2018-10-142-13/+13
|/ /
* | Merge branch 'PHP-7.2'Anatol Belski2018-07-302-0/+119
|\ \ | |/ | | | | | | * PHP-7.2: Fixed bug #75402 Possible Memory Leak using PDO::CURSOR_SCROLL option
| * Merge branch 'PHP-7.1' into PHP-7.2Anatol Belski2018-07-302-0/+119
| |\ | | | | | | | | | | | | * PHP-7.1: Fixed bug #75402 Possible Memory Leak using PDO::CURSOR_SCROLL option
| | * Fixed bug #75402 Possible Memory Leak using PDO::CURSOR_SCROLL optionAnatol Belski2018-07-302-0/+119
| | |
* | | Fix typos in codePeter Kokot2018-07-271-1/+1
| | |
* | | Remove unused Git attributes identPeter Kokot2018-07-256-10/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The $Id$ keywords were used in Subversion where they can be substituted with filename, last revision number change, last changed date, and last user who changed it. In Git this functionality is different and can be done with Git attribute ident. These need to be defined manually for each file in the .gitattributes file and are afterwards replaced with 40-character hexadecimal blob object name which is based only on the particular file contents. This patch simplifies handling of $Id$ keywords by removing them since they are not used anymore.